Skip to content

Commit

Permalink
[Autofill] Fix duplicate definition of kIbanValue
Browse files Browse the repository at this point in the history
This is causing compilation errors on ChromeOS because
chrome/browser/ui/views/autofill/payments/iban_bubble_view_uitest.cc
and components/autofill/core/browser/autofill_test_utils.h both
define `kIbanValue`.

Bug: 1007974
Change-Id: I2c4fa99462bedec644cf09624ab82601ccf21a36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4350451
Reviewed-by: Michael Lerman <mlerman@chromium.org>
Commit-Queue: Christoph Schwering <schwering@google.com>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1119104}
  • Loading branch information
schwering authored and Chromium LUCI CQ committed Mar 19, 2023
1 parent 5331e6b commit 3fcf823
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions components/autofill/core/browser/autofill_test_utils.h
Expand Up @@ -28,10 +28,6 @@

class PrefService;

namespace {
constexpr char kIbanValue[] = "IE64 IRCE 9205 0112 3456 78";
} // namespace

namespace user_prefs {
class PrefRegistrySyncable;
} // namespace user_prefs
Expand Down Expand Up @@ -264,7 +260,7 @@ void CreateTestCreditCardFormData(FormData* form,
// single IBAN field). Note that this actually appends fields to the form data,
// which can be useful for building up more complex test forms.
void CreateTestIbanFormData(FormData* form_data,
const char* value = kIbanValue);
const char* value = "IE64 IRCE 9205 0112 3456 78");

// Strips those members from |form| and |field| that are not serialized via
// mojo, i.e., resets them to `{}`.
Expand Down

0 comments on commit 3fcf823

Please sign in to comment.