Skip to content

Commit

Permalink
Disable PushNotificationClientManagerTest.BrowserReady on ios-asan
Browse files Browse the repository at this point in the history
This test has been failing on ASAN since it was added in:
https://chromium-review.googlesource.com/c/chromium/src/+/4484885

(cherry picked from commit 8c75956)

Bug: 1449081
Change-Id: Ib624245cc90bb7ba69503d895a9265439a475968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4570105
Owners-Override: Alan Cutter <alancutter@google.com>
Reviewed-by: Louise Brett <loubrett@google.com>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1149532}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4591738
Owners-Override: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/branch-heads/5790@{#382}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
  • Loading branch information
alancutter authored and Chromium LUCI CQ committed Jun 5, 2023
1 parent c31c048 commit 409d62d
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,13 @@ void GenerateClients(std::unique_ptr<PushNotificationClientManager>& manager,
}
}

TEST_F(PushNotificationClientManagerTest, BrowserReady) {
// TODO(crbug.com/1449081): Fails on ASAN
#if defined(ADDRESS_SANITIZER)
#define MAYBE_BrowserReady DISABLED_BrowserReady
#else
#define MAYBE_BrowserReady BrowserReady
#endif
TEST_F(PushNotificationClientManagerTest, MAYBE_BrowserReady) {
GenerateClients(manager, 1);
EXPECT_FALSE(GetClient(manager, 0)->IsBrowserReady());
manager->OnSceneActiveForegroundBrowserReady();
Expand Down

0 comments on commit 409d62d

Please sign in to comment.