Roll src/third_party/breakpad/breakpad/ e3d485f73..46f4b593e (21 comm…

…its)

https://chromium.googlesource.com/breakpad/breakpad.git/+log/e3d485f73f58..46f4b593eef3

$ git log e3d485f73..46f4b593e --date=short --no-merges --format='%ad %ae %s'
2021-03-02 justincohen Automatically capture debugID in Mac OS symupload tool.
2021-02-24 vapier switch repo manifest to track the main branch
2021-02-11 vapier restore gtest updates
2021-02-06 sunsj1231 arm: Allow the first function to use linked register as return pc
2021-02-06 sunsj1231 readme: Change default branch from master to main
2021-02-06 sunsj1231 Add core_handler and pid2md into git ignore
2021-01-29 hashimoto Add src/processor/stackwalk_common.{cc,h} to src_libbreakpad_a_SOURCES
2021-01-21 cmtice breakpad: Fix typo in unit test.
2021-01-20 cmtice breakpad: Eliminate 'unused variable' warnings.
2021-01-16 cmtice Dwarf5 fixes [5 of 5]: Recognize dwp version 5.
2021-01-16 cmtice Dwarf5 fixes [4 of 5]: Skip processing Dwarf5 type units.
2021-01-16 cmtice Dwarf5 fixes [3 of 5]: Fix bugs reading .debug_line_str.
2021-01-16 cmtice Dwarf5 fixes [2 of 5]: Handle .debug_str_offsets properly.
2021-01-16 cmtice Dwarf5 fixes [1 of 5]: Add & use missing enums, fix typo.
2021-01-04 vapier update to newer googletest
2020-12-21 epastor Do not build core_handler unless memfd_create is available
2020-12-14 snehasishk Add a test to check debug information for split functions.
2020-12-11 snehasishk Add dwarf2reader unit test to run with make check.
2020-12-10 snehasishk Fix a typo in lineinfo unittest.cc
2020-11-24 ludovic.guegan pid2md: generate a minidump from a running process
2020-11-23 ludovic.guegan core_handler: coredump handler to produce minidump

Created with:
  roll-dep src/third_party/breakpad/breakpad

(cherry picked from commit cbf1c8f)

Bug: 1179132
Change-Id: I67790a39d848d0d69df74033d1fc6ec84625458c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2729361
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#859397}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2747961
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4430@{#307}
Cr-Branched-From: e5ce7dc-refs/heads/master@{#857950}

DEPS

@@ -856,7 +856,7 @@ deps = {
   },
 
   'src/third_party/breakpad/breakpad':
-    Var('chromium_git') + '/breakpad/breakpad.git' + '@' + 'e3d485f73f5836fdd6fb287ab96973c4f63175e1',
+    Var('chromium_git') + '/breakpad/breakpad.git' + '@' + '46f4b593eef345754111509839a96a7eb965192f',
 
   'src/third_party/byte_buddy': {
       'packages': [

third_party/breakpad/BUILD.gn

@@ -278,7 +278,7 @@ if (!is_win) {
 
 if (is_mac) {
   if (current_toolchain == host_toolchain) {
-    executable("dump_syms") {
+    source_set("common") {
       sources = [
         "breakpad/src/common/dwarf/bytereader.cc",
         "breakpad/src/common/dwarf/dwarf2diehandler.cc",
@@ -307,24 +307,31 @@ if (is_mac) {
         "breakpad/src/common/scoped_ptr.h",
         "breakpad/src/common/stabs_reader.cc",
         "breakpad/src/common/stabs_to_module.cc",
-        "breakpad/src/tools/mac/dump_syms/dump_syms_tool.cc",
       ]
-
-      # For breakpad/src/common/stabs_reader.h.
-      defines = [ "HAVE_MACH_O_NLIST_H" ]
       include_dirs = [ "breakpad/src/common/mac" ]
 
+      configs += [ ":internal_config" ]
+
       # The DWARF utilities require -funsigned-char.
       cflags = [ "-funsigned-char" ]
 
-      configs += [ ":internal_config" ]
+      # dwarf2reader.cc uses dynamic_cast.
+      configs -= [ "//build/config/compiler:no_rtti" ]
+      configs += [ "//build/config/compiler:rtti" ]
 
       configs -= [ "//build/config/compiler:chromium_code" ]
       configs += [ "//build/config/compiler:no_chromium_code" ]
 
-      # dwarf2reader.cc uses dynamic_cast.
-      configs -= [ "//build/config/compiler:no_rtti" ]
-      configs += [ "//build/config/compiler:rtti" ]
+      # For breakpad/src/common/stabs_reader.h.
+      defines = [ "HAVE_MACH_O_NLIST_H" ]
+    }
+
+    executable("dump_syms") {
+      sources = [ "breakpad/src/tools/mac/dump_syms/dump_syms_tool.cc" ]
+      configs -= [ "//build/config/compiler:chromium_code" ]
+      configs += [ "//build/config/compiler:no_chromium_code" ]
+
+      configs += [ ":internal_config" ]
 
       frameworks = [ "Foundation.framework" ]
 
@@ -334,8 +341,10 @@ if (is_mac) {
         # at -O0 until this can be sorted out.
         # https://crbug.com/google-breakpad/329
         configs -= [ "//build/config/compiler:default_optimization" ]
-        cflags += [ "-O0" ]
+        cflags = [ "-O0" ]
       }
+
+      deps = [ ":common" ]
     }
 
     executable("symupload") {
@@ -347,15 +356,19 @@ if (is_mac) {
         "breakpad/src/common/mac/HTTPSimplePostRequest.m",
         "breakpad/src/common/mac/SymbolCollectorClient.m",
         "breakpad/src/common/mac/encoding_util.m",
-        "breakpad/src/tools/mac/symupload/symupload.m",
+        "breakpad/src/tools/mac/symupload/symupload.mm",
       ]
 
       include_dirs = [ "breakpad/src/common/mac" ]
 
+      configs += [ ":internal_config" ]
+
       frameworks = [ "Foundation.framework" ]
 
       configs -= [ "//build/config/compiler:chromium_code" ]
       configs += [ "//build/config/compiler:no_chromium_code" ]
+
+      deps = [ ":common" ]
     }
   } else {
     binary_symlink("dump_syms") {