-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[AA WebLayer] Add static Java WebLayer dependencies
We are in the process of launching Autofill Assistant on WebLayer. In this cl we add the first static dependencies class and create a separate Autofill Assistant target to keep the binary size impact on WebLayer and WebView minimal. Bug: b/222671580 Change-Id: I859f7457f0be4c1f07d3346ce81f6f2c22ad1aea Binary-Size: We are adding Autofill Assistant to WebLayer. This is a necessary change to keep Autofill Assistant running if Apps change from CCT to WebLayer. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3525116 Auto-Submit: Florian Gauger <fga@google.com> Reviewed-by: Sandro Maggi <sandromaggi@google.com> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/main@{#987392}
- Loading branch information
Florian Gauger
authored and
Chromium LUCI CQ
committed
Mar 31, 2022
1 parent
58a0db3
commit 41f3c43
Showing
10 changed files
with
212 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
126 changes: 126 additions & 0 deletions
126
...org/chromium/weblayer_private/autofill_assistant/WebLayerAssistantStaticDependencies.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| // Copyright 2022 The Chromium Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| package org.chromium.weblayer_private.autofill_assistant; | ||
|
|
||
| import android.app.Activity; | ||
| import android.content.Context; | ||
|
|
||
| import androidx.annotation.DimenRes; | ||
| import androidx.annotation.Nullable; | ||
|
|
||
| import org.chromium.components.autofill_assistant.AssistantAccessTokenUtil; | ||
| import org.chromium.components.autofill_assistant.AssistantDependencies; | ||
| import org.chromium.components.autofill_assistant.AssistantEditorFactory; | ||
| import org.chromium.components.autofill_assistant.AssistantFeedbackUtil; | ||
| import org.chromium.components.autofill_assistant.AssistantInfoPageUtil; | ||
| import org.chromium.components.autofill_assistant.AssistantProfileImageUtil; | ||
| import org.chromium.components.autofill_assistant.AssistantSettingsUtil; | ||
| import org.chromium.components.autofill_assistant.AssistantStaticDependencies; | ||
| import org.chromium.components.autofill_assistant.AssistantTabObscuringUtil; | ||
| import org.chromium.components.autofill_assistant.AssistantTabUtil; | ||
| import org.chromium.components.favicon.LargeIconBridge; | ||
| import org.chromium.components.image_fetcher.ImageFetcher; | ||
| import org.chromium.content_public.browser.BrowserContextHandle; | ||
| import org.chromium.ui.base.WindowAndroid; | ||
| import org.chromium.ui.util.AccessibilityUtil; | ||
| import org.chromium.weblayer_private.WebLayerAccessibilityUtil; | ||
|
|
||
| /** | ||
| * Provides default implementations of {@link AssistantStaticDependencies} for WebLayer. | ||
| */ | ||
| public class WebLayerAssistantStaticDependencies implements AssistantStaticDependencies { | ||
| @Override | ||
| public long createNative() { | ||
| // TODO(b/222671580): Implement | ||
| return 0; | ||
| } | ||
|
|
||
| @Override | ||
| public AssistantDependencies createDependencies(Activity activity) { | ||
| // TODO(b/222671580): Implement | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public AccessibilityUtil getAccessibilityUtil() { | ||
| return WebLayerAccessibilityUtil.get(); | ||
| } | ||
|
|
||
| @Override | ||
| @Nullable | ||
| public AssistantTabObscuringUtil getTabObscuringUtilOrNull(WindowAndroid windowAndroid) { | ||
| // TODO(b/222671580): Implement | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public AssistantInfoPageUtil createInfoPageUtil() { | ||
| // TODO(b/222671580): Implement | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public AssistantFeedbackUtil createFeedbackUtil() { | ||
| // TODO(b/222671580): Implement | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public AssistantTabUtil createTabUtil() { | ||
| // TODO(b/222671580): Implement | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public AssistantSettingsUtil createSettingsUtil() { | ||
| // TODO(b/222671580): Implement | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public AssistantAccessTokenUtil createAccessTokenUtil() { | ||
| // TODO(b/222671580): Implement | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public BrowserContextHandle getBrowserContext() { | ||
| // TODO(b/222671580): Implement | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public ImageFetcher createImageFetcher() { | ||
| // TODO(b/222671580): Implement | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public LargeIconBridge createIconBridge() { | ||
| // TODO(b/222671580): Implement | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| @Nullable | ||
| public String getSignedInAccountEmailOrNull() { | ||
| // TODO(b/222671580): Implement | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| @Nullable | ||
| public AssistantProfileImageUtil createProfileImageUtilOrNull( | ||
| Context context, @DimenRes int imageSizeRedId) { | ||
| // TODO(b/222671580): Implement | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public AssistantEditorFactory createEditorFactory() { | ||
| // TODO(b/222671580): Implement | ||
| return null; | ||
| } | ||
| } |