Skip to content

Commit

Permalink
Revert "Remove tools/clang/scripts/download_objdump.py"
Browse files Browse the repository at this point in the history
This reverts commit 29c801b.

Reason for revert:
The official/chrome/chrome_android recipe (which does not show up
on internal code search) uses this, and that recipe also builds the 
M78 and M79 branches , so can't be migrated to use the new update.py
flag yet.

We'll have to keep this around until all builds are targeting M80 or
later.

Original change's description:
> Remove tools/clang/scripts/download_objdump.py
> 
> All uses have been replaced by calls to update.py --package=objdump.
> 
> Bug: 884608
> Change-Id: Icb820782786a256c0a3586e8a23f62d463689afb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917517
> Auto-Submit: Hans Wennborg <hans@chromium.org>
> Commit-Queue: Reid Kleckner <rnk@chromium.org>
> Reviewed-by: Reid Kleckner <rnk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#715750}

TBR=hans@chromium.org,rnk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

(cherry picked from commit ada1ef3)

Bug: 884608, 1025703
Change-Id: Ib048dfcbd91f4f5201a6b77525189e6185dc7e80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921977
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#716151}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921214
Reviewed-by: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/branch-heads/3970@{#4}
Cr-Branched-From: 55f4451-refs/heads/master@{#716057}
  • Loading branch information
zmodem authored and Ben Mason committed Nov 18, 2019
1 parent 315f609 commit 44c4d50
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions tools/clang/scripts/download_objdump.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#!/usr/bin/env python
# Copyright 2017 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

import sys

import update

# TODO(hans): Remove this forwarding hack after all callers of this script have
# been updated to call update.py instead.
if __name__ == '__main__':
sys.argv = [sys.argv[0], '--package=objdump']
sys.exit(update.main())

0 comments on commit 44c4d50

Please sign in to comment.