Skip to content

Commit

Permalink
CrOS Settings: Convert peoples page sync from JS to TS
Browse files Browse the repository at this point in the history
Bug= b:263413628
TEST=
1. Run:
    a. `autoninja -C out/Default browser_tests && DISPLAY=:20 out/Default/browser_tests  --gtest_filter="*PeoplePage*"`
    b. `autoninja -C out/Default webui_closure_compile`
2. Manual UI Test

Change-Id: Idc146f2acf4620efad059ae972c21d08489473e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4201314
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Nikki Moteva <moteva@google.com>
Cr-Commit-Position: refs/heads/main@{#1099600}
  • Loading branch information
Moteva authored and Chromium LUCI CQ committed Feb 1, 2023
1 parent 0ed3842 commit 450b60a
Show file tree
Hide file tree
Showing 7 changed files with 206 additions and 357 deletions.
5 changes: 1 addition & 4 deletions chrome/browser/resources/settings/chromeos/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -265,10 +265,7 @@ generate_grd("build_grd") {
# TODO(crbug/1315757) Gradually remove closure compilation for subfolders/pages
# that are migrated to TypeScript
group("closure_compile_module") {
deps = [
":closure_compile_local_module",
"os_people_page:closure_compile_module",
]
deps = [ ":closure_compile_local_module" ]
}

js_type_check("closure_compile_local_module") {
Expand Down
52 changes: 0 additions & 52 deletions chrome/browser/resources/settings/chromeos/os_people_page/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ js_type_check("closure_compile_module") {
":lock_screen",
":lock_screen_password_prompt_dialog",
":lock_state_behavior",
":os_people_page",
":os_sync_browser_proxy",
":os_sync_controls",
":setup_fingerprint_dialog",
":setup_pin_dialog",
]
Expand Down Expand Up @@ -128,55 +125,6 @@ js_library("lock_state_behavior") {
extra_sources = [ "$interfaces_path/quick_unlock_private_interface.js" ]
}

js_library("os_people_page") {
deps = [
":account_manager_browser_proxy",
":lock_screen",
":lock_state_behavior",
":os_sync_controls",
"..:deep_linking_behavior",
"..:icon",
"..:os_page_visibility",
"..:os_route",
"..:route_observer_behavior",
"..:router",
"//ash/webui/common/resources:assert",
"//ash/webui/common/resources:focus_without_ink_js",
"//ash/webui/common/resources:i18n_behavior",
"//ash/webui/common/resources:load_time_data.m",
"//ash/webui/common/resources:web_ui_listener_behavior",
"//ash/webui/common/resources/cr_picture:png",
"//ash/webui/common/resources/quick_unlock:lock_screen_constants",
"//third_party/polymer/v3_0/components-chromium/polymer:polymer_bundled",
]
externs_list =
chrome_extension_public_externs + [ "../settings_controls_types.js" ]
}

js_library("os_sync_browser_proxy") {
deps = [
"//ash/webui/common/resources:cr.m",
"//ash/webui/common/resources:load_time_data.m",
"//third_party/polymer/v3_0/components-chromium/polymer:polymer_bundled",
]
}

js_library("os_sync_controls") {
deps = [
":os_sync_browser_proxy",
"..:deep_linking_behavior",
"..:metrics_recorder",
"..:os_route",
"..:router",
"//ash/webui/common/resources:assert",
"//ash/webui/common/resources:load_time_data.m",
"//ash/webui/common/resources:web_ui_listener_behavior",
"//third_party/polymer/v3_0/components-chromium/polymer:polymer_bundled",
]
externs_list =
[ "//ui/webui/resources/cr_elements/cr_toggle/cr_toggle_externs.js" ]
}

js_library("setup_fingerprint_dialog") {
deps = [
":fingerprint_browser_proxy",
Expand Down

0 comments on commit 450b60a

Please sign in to comment.