-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Merge to M-103]capture_mode: Make select capture region work properly
This CL fixed the issue that capture region is not selectable nor draggable after start pressing on the capture bar or settings and then release the press outsiede of it. To fix it, we should let the event targeted on the capture bar or settings go through and to be handled by it instead of setting the event as handled and stopping propagation. (cherry picked from commit 7674929) Test: Manual, added a regression test Change-Id: I8f5fbbd30d95f0fd520a67a32fcac5c9a04f9869 Fixed: 1325028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645696 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1002973} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648909 Commit-Queue: Connie Xu <conniekxu@chromium.org> Cr-Commit-Position: refs/branch-heads/5060@{#18} Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
- Loading branch information
conniekxu
authored and
Chromium LUCI CQ
committed
May 16, 2022
1 parent
0dfb733
commit 45e34cd
Showing
3 changed files
with
37 additions
and
34 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters