-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[NTP] Don't show Customize Chrome promo when signin modal dialog is open
This CL avoids showing the Customize Chrome IPH promo when a Signin modal dialog is open (Sync Confirmation or Profile Customization). It will be shown in the next NTP. Demo of the current behavior: https://screencast.googleplex.com/cast/NTk2MDg5MzM2OTE1NTU4NHxmNzRmYWIwZC1iNQ https://screencast.googleplex.com/cast/NDUzOTUxODkzOTAzNzY5Nnw2MjU1NjUwNC0wMw Preview: https://screencast.googleplex.com/cast/NjI5NTQ2NzAyNjU0NjY4OHw1ZmNiYzFlNS0zMw Bug: 1444999 Change-Id: Id32d67cea6861d82f833a0299050dc66fbf10051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4580748 Commit-Queue: Gabriel Oliveira <gabolvr@google.com> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Paul Adedeji <pauladedeji@google.com> Cr-Commit-Position: refs/heads/main@{#1153865}
- Loading branch information
Gabriel Oliveira
authored and
Chromium LUCI CQ
committed
Jun 6, 2023
1 parent
82d3fef
commit 4692c79
Showing
4 changed files
with
41 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters