Skip to content

Commit

Permalink
Get rid of DomTracker
Browse files Browse the repository at this point in the history
NodeId's can be invalidated between remote calls.
Use of NodeId's can lead to errors with unresolved nodes.

Bug: chromedriver:4048
Change-Id: I6d60587a2f6da97bf5b71c440bca2396625296f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3634385
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Vladimir Nechaev <nechaev@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1001507}
  • Loading branch information
nechaev-chromium authored and Chromium LUCI CQ committed May 10, 2022
1 parent 8805f4d commit 481b75f
Show file tree
Hide file tree
Showing 10 changed files with 264 additions and 473 deletions.
3 changes: 0 additions & 3 deletions chrome/test/chromedriver/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,6 @@ source_set("automation_client_lib") {
"chrome/devtools_event_listener.h",
"chrome/devtools_http_client.cc",
"chrome/devtools_http_client.h",
"chrome/dom_tracker.cc",
"chrome/dom_tracker.h",
"chrome/download_directory_override_manager.cc",
"chrome/download_directory_override_manager.h",
"chrome/frame_tracker.cc",
Expand Down Expand Up @@ -419,7 +417,6 @@ test("chromedriver_unittests") {
"chrome/devtools_client_impl_unittest.cc",
"chrome/devtools_endpoint_unittest.cc",
"chrome/devtools_http_client_unittest.cc",
"chrome/dom_tracker_unittest.cc",
"chrome/download_directory_override_manager_unittest.cc",
"chrome/frame_tracker_unittest.cc",
"chrome/geolocation_override_manager_unittest.cc",
Expand Down
256 changes: 0 additions & 256 deletions chrome/test/chromedriver/chrome/dom_tracker.cc

This file was deleted.

48 changes: 0 additions & 48 deletions chrome/test/chromedriver/chrome/dom_tracker.h

This file was deleted.

0 comments on commit 481b75f

Please sign in to comment.