-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CrOS Settings: Convert borealis detail view browser test to TS
Additionally, moved the test under the `os_apps_page/app_management_page` folder to mirror the app folder structure. gtest_filter="*OsAppsPageAppManagementPageBorealisDetailView*" Bug: b/270728282 Test: browser_tests -- Change-Id: I30a4aefb3d3450299a07d0d8c0bab0738613a4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4569203 Reviewed-by: Wes Okuhara <wesokuhara@google.com> Commit-Queue: Ruma Kesh <rkesh@google.com> Cr-Commit-Position: refs/heads/main@{#1150796}
- Loading branch information
1 parent
0ee1819
commit 485e573
Showing
8 changed files
with
187 additions
and
145 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
136 changes: 0 additions & 136 deletions
136
chrome/test/data/webui/settings/chromeos/app_management/borealis_detail_view_test.js
This file was deleted.
Oops, something went wrong.
176 changes: 176 additions & 0 deletions
176
...ata/webui/settings/chromeos/os_apps_page/app_management_page/borealis_detail_view_test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,176 @@ | ||
| // Copyright 2021 The Chromium Authors | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import 'chrome://os-settings/lazy_load.js'; | ||
|
|
||
| import {AppManagementBorealisDetailViewElement, AppManagementPinToShelfItemElement} from 'chrome://os-settings/lazy_load.js'; | ||
| import {AppManagementStore, Router, updateSelectedAppId} from 'chrome://os-settings/os_settings.js'; | ||
| import {App, AppType, Permission, PermissionType} from 'chrome://resources/cr_components/app_management/app_management.mojom-webui.js'; | ||
| import {PermissionTypeIndex} from 'chrome://resources/cr_components/app_management/permission_constants.js'; | ||
| import {createBoolPermission} from 'chrome://resources/cr_components/app_management/permission_util.js'; | ||
| import {AppManagementToggleRowElement} from 'chrome://resources/cr_components/app_management/toggle_row.js'; | ||
| import {convertOptionalBoolToBool, getPermissionValueBool} from 'chrome://resources/cr_components/app_management/util.js'; | ||
| import {CrToggleElement} from 'chrome://resources/cr_elements/cr_toggle/cr_toggle.js'; | ||
| import {assertEquals, assertFalse, assertNull, assertTrue} from 'chrome://webui-test/chai_assert.js'; | ||
| import {flushTasks} from 'chrome://webui-test/polymer_test_util.js'; | ||
| import {eventToPromise} from 'chrome://webui-test/test_util.js'; | ||
|
|
||
| import {FakePageHandler} from '../../app_management/fake_page_handler.js'; | ||
| import {getPermissionCrToggleByType, getPermissionToggleByType, replaceBody, replaceStore, setupFakeHandler} from '../../app_management/test_util.js'; | ||
|
|
||
| suite('<app-management-borealis-detail-view>', () => { | ||
| let borealisDetailView: AppManagementBorealisDetailViewElement; | ||
| let fakeHandler: FakePageHandler; | ||
|
|
||
| const BOREALIS_CLIENT_APP_ID = 'epfhbkiklgmlkhfpbcdleadnhcfdjfmo'; | ||
|
|
||
| function getPermissionBoolByType(permissionType: PermissionTypeIndex): | ||
| boolean { | ||
| return getPermissionValueBool( | ||
| borealisDetailView.get('app_'), permissionType); | ||
| } | ||
|
|
||
| async function clickToggle(permissionType: PermissionTypeIndex): | ||
| Promise<void> { | ||
| const toggleRow = | ||
| getPermissionToggleByType(borealisDetailView, permissionType) as | ||
| AppManagementToggleRowElement; | ||
| toggleRow.click(); | ||
| await fakeHandler.flushPipesForTesting(); | ||
| } | ||
|
|
||
| function getSelectedAppFromStore(): App { | ||
| const storeData = AppManagementStore.getInstance().data; | ||
| assertTrue(!!storeData); | ||
| const selectedAppId = storeData.selectedAppId; | ||
| assertTrue(!!selectedAppId); | ||
| const selectedApp = storeData.apps[selectedAppId]; | ||
| assertTrue(!!selectedApp); | ||
| return selectedApp; | ||
| } | ||
|
|
||
| setup(async () => { | ||
| fakeHandler = setupFakeHandler(); | ||
| replaceStore(); | ||
|
|
||
| const permissions: {[key in PermissionType]?: Permission} = {}; | ||
| const permissionTypes = [PermissionType.kMicrophone]; | ||
| for (const permissionType of permissionTypes) { | ||
| permissions[permissionType] = createBoolPermission( | ||
| permissionType, true /*permission_value*/, false /*is_managed*/); | ||
| } | ||
|
|
||
| // Add main app, and make it the currently selected app. | ||
| const mainOptions = { | ||
| type: AppType.kBorealis, | ||
| permissions: permissions, | ||
| }; | ||
| const mainApp = | ||
| await fakeHandler.addApp(BOREALIS_CLIENT_APP_ID, mainOptions); | ||
| AppManagementStore.getInstance().dispatch(updateSelectedAppId(mainApp.id)); | ||
| borealisDetailView = | ||
| document.createElement('app-management-borealis-detail-view'); | ||
| replaceBody(borealisDetailView); | ||
| }); | ||
|
|
||
| teardown(() => { | ||
| borealisDetailView.remove(); | ||
| Router.getInstance().resetRouteForTesting(); | ||
| }); | ||
|
|
||
| test('App is rendered correctly', () => { | ||
| assertEquals( | ||
| AppManagementStore.getInstance().data.selectedAppId, | ||
| borealisDetailView.get('app_').id); | ||
| }); | ||
|
|
||
| // TODO(b/270728282) - remove "as" cast once getPermissionCrToggleByType() | ||
| // becomes a TS function. | ||
| test('Toggle permissions', async () => { | ||
| const checkToggle = async (permissionType: PermissionTypeIndex) => { | ||
| assertTrue(getPermissionBoolByType(permissionType)); | ||
| let toggle = getPermissionCrToggleByType( | ||
| borealisDetailView, permissionType) as CrToggleElement; | ||
| assertTrue(toggle.checked); | ||
|
|
||
| // Toggle off. | ||
| await clickToggle(permissionType); | ||
| assertFalse(getPermissionBoolByType(permissionType)); | ||
| toggle = getPermissionCrToggleByType( | ||
| borealisDetailView, permissionType) as CrToggleElement; | ||
| assertFalse(toggle.checked); | ||
|
|
||
| // Toggle on. | ||
| await clickToggle(permissionType); | ||
| assertTrue(getPermissionBoolByType(permissionType)); | ||
| toggle = getPermissionCrToggleByType( | ||
| borealisDetailView, permissionType) as CrToggleElement; | ||
| assertTrue(toggle.checked); | ||
| }; | ||
|
|
||
| await checkToggle('kMicrophone'); | ||
| }); | ||
|
|
||
| test('Pin to shelf toggle', async () => { | ||
| const pinToShelfItem = | ||
| borealisDetailView.shadowRoot! | ||
| .querySelector<AppManagementPinToShelfItemElement>( | ||
| '#pinToShelfSetting'); | ||
| assertTrue(!!pinToShelfItem); | ||
| const toggleRow = | ||
| pinToShelfItem.shadowRoot!.querySelector<AppManagementToggleRowElement>( | ||
| '#toggleRow'); | ||
| assertTrue(!!toggleRow); | ||
| const toggle = toggleRow.$.toggle; | ||
|
|
||
| let selectedAppId = getSelectedAppFromStore(); | ||
| assertTrue(!!selectedAppId); | ||
| assertFalse(toggle.checked); | ||
| assertEquals( | ||
| toggle.checked, convertOptionalBoolToBool(selectedAppId.isPinned)); | ||
| pinToShelfItem.click(); | ||
| await fakeHandler.flushPipesForTesting(); | ||
| assertTrue(toggle.checked); | ||
| selectedAppId = getSelectedAppFromStore(); | ||
| assertTrue(!!selectedAppId); | ||
| assertEquals( | ||
| toggle.checked, convertOptionalBoolToBool(selectedAppId.isPinned)); | ||
| pinToShelfItem.click(); | ||
| await fakeHandler.flushPipesForTesting(); | ||
| assertFalse(toggle.checked); | ||
| selectedAppId = getSelectedAppFromStore(); | ||
| assertTrue(!!selectedAppId); | ||
| assertEquals( | ||
| toggle.checked, convertOptionalBoolToBool(selectedAppId.isPinned)); | ||
| }); | ||
|
|
||
| test('Permission info links are correct', async () => { | ||
| assertTrue(!!borealisDetailView.shadowRoot!.querySelector('#mainLink')); | ||
| assertNull(borealisDetailView.shadowRoot!.querySelector('#borealisLink')); | ||
|
|
||
| // Add borealis (non main) app. Note that any tests after this will | ||
| // have the borealis app selected as default. | ||
| const options = { | ||
| type: AppType.kBorealis, | ||
| }; | ||
| const app = await fakeHandler.addApp('foo', options); | ||
| AppManagementStore.getInstance().dispatch(updateSelectedAppId(app.id)); | ||
| await fakeHandler.flushPipesForTesting(); | ||
| assertNull(borealisDetailView.shadowRoot!.querySelector('#mainLink')); | ||
| assertTrue(!!borealisDetailView.shadowRoot!.querySelector('#borealisLink')); | ||
|
|
||
| // Check that link directs to main app page. | ||
| const link = borealisDetailView.shadowRoot!.querySelector('#borealisLink'); | ||
| assertTrue(!!link); | ||
| const anchorTag = link.shadowRoot!.querySelector('a'); | ||
| assertTrue(!!anchorTag); | ||
| const localizedLinkPromise = eventToPromise('link-clicked', link); | ||
| anchorTag.click(); | ||
| await Promise.all([localizedLinkPromise, flushTasks()]); | ||
| await fakeHandler.flushPipesForTesting(); | ||
| assertEquals( | ||
| Router.getInstance().getQueryParameters().get('id'), | ||
| BOREALIS_CLIENT_APP_ID); | ||
| }); | ||
| }); |
Oops, something went wrong.