Skip to content

Commit

Permalink
[sticky] Disable LayoutIgnoreMarginsForSticky
Browse files Browse the repository at this point in the history
Unfortunately may need to live with this behaviour until we have a
solution for placing sticky-pos elements relative to each other.

(cherry picked from commit fe4f873)

Bug: 1485507
Change-Id: If5de077eb0d087a1eb376791f79c19b8095f5b6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4896251
Commit-Queue: Robert Flack <flackr@chromium.org>
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1203327}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4907111
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5993@{#1067}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
  • Loading branch information
bfgeek authored and Chromium LUCI CQ committed Oct 2, 2023
1 parent 25cd169 commit 4cc7a76
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2156,7 +2156,6 @@
},
{
name: "LayoutIgnoreMarginsForSticky",
status: "stable",
},
{
name: "LayoutNewFixedPositionInvalidation",
Expand Down
3 changes: 0 additions & 3 deletions third_party/blink/web_tests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -841,9 +841,6 @@ crbug.com/922249 virtual/android/fullscreen/compositor-touch-hit-rects-fullscree
# Fractional paint offsets lead to 1px bleed with position sticky.
crbug.com/1136079 external/wpt/css/css-position/sticky/position-sticky-fractional-offset.html [ Failure ]

# Temporary failure see: https://github.com/w3c/csswg-drafts/issues/9052
crbug.com/1466293 external/wpt/css/css-position/sticky/position-sticky-margins.html [ Failure ]

# ====== Layout team owned tests from here ======

crbug.com/711704 external/wpt/css/CSS2/floats/floats-rule3-outside-left-002.xht [ Failure ]
Expand Down

0 comments on commit 4cc7a76

Please sign in to comment.