Skip to content

Commit

Permalink
Remove can_be_recommended from multiple policies.
Browse files Browse the repository at this point in the history
The affected policies cannot be configured by users in Chrome, so
recommended support no longer makes sense.

This change is accounced in the enterprise release notes to give admins
time to switch the policies from recommended to mandatory:
https://chromestatus.com/feature/5101898193698816

Bug: N/A
Change-Id: I7c8986be8d456f3d3247b2ac162edbf21fb57076
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4935729
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1214870}
  • Loading branch information
Igor Ruvinov authored and Chromium LUCI CQ committed Oct 25, 2023
1 parent a6ce7f3 commit 4d1a682
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ desc: |-
If you set the policy, users can't change it. If not set, the policy is on, but users can change this setting.
example_value: true
features:
can_be_recommended: true
dynamic_refresh: true
per_profile: true
future_on:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ desc: |-
On <ph name="MS_WIN_NAME">Microsoft® Windows®</ph>, this policy is only available on instances that are joined to a <ph name="MS_AD_NAME">Microsoft® Active Directory®</ph> domain, joined to <ph name="MS_AAD_NAME">Microsoft® Azure® Active Directory®</ph> or enrolled in <ph name="CHROME_BROWSER_CLOUD_MANAGEMENT_NAME">Chrome Browser Cloud Management</ph>.
example_value: false
features:
can_be_recommended: true
dynamic_refresh: true
per_profile: true
items:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ desc: |-
If you disable this setting, users will not be able to dismiss alerts about compromised passwords. If enabled, users will be able to dismiss alerts about compromised passwords.
example_value: true
features:
can_be_recommended: true
dynamic_refresh: true
per_profile: true
future_on:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,11 @@ caption: Enable leak detection for entered credentials
desc: |-
Setting the policy to Enabled lets users have <ph name="PRODUCT_NAME">$1<ex>Google Chrome</ex></ph> check whether usernames and passwords entered were part of a leak.
If the policy is set, users can't change it in <ph name="PRODUCT_NAME">$1<ex>Google Chrome</ex></ph>. If not set, credential leak checking is allowed, but the user can turn it off. 
If the policy is set, users can't change it in <ph name="PRODUCT_NAME">$1<ex>Google Chrome</ex></ph>. If not set, credential leak checking is allowed, but the user can turn it off.
This behavior will not trigger if Safe Browsing is disabled (either by policy or by the user). In order to force Safe Browsing on, use the <ph name="SAFE_BROWSING_ENABLED_POLICY_NAME">SafeBrowsingEnabled</ph> policy or the <ph name="SAFE_BROWSING_PROTETION_LEVEL_POLICY_NAME">SafeBrowsingProtectionLevel</ph> policy.
example_value: true
features:
can_be_recommended: true
dynamic_refresh: true
per_profile: true
future_on:
Expand Down

0 comments on commit 4d1a682

Please sign in to comment.