Skip to content

Commit

Permalink
[Live Caption] Added Ash "ui driver" impl.
Browse files Browse the repository at this point in the history
In order to render lacros live captions in Ash, information about lacros
tabs (e.g. their bounds in screen) will have to be piped over crosapi
between the two processes.

This CL adds the (currently un-instantiated) Ash-side logic needed to
coordinate the bubble rendering.

Note that there are a number of "ForTesting" methods added in this CL,
because friend classes would introduce layering problems (::ash friend
classes of ::views classes).

For feature architecture, see: http://shortn/_EMDhvK67dP

AX-Relnotes: n/a
Bug: b:262804862
Change-Id: Ifb560e3b640109b3dbabfff7484b04ed543dc6a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4170037
Reviewed-by: Abigail Klein <abigailbklein@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Michael Martis <martis@chromium.org>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1096531}
  • Loading branch information
martis-chromium authored and Chromium LUCI CQ committed Jan 25, 2023
1 parent 2ebd828 commit 4f485e4
Show file tree
Hide file tree
Showing 11 changed files with 555 additions and 4 deletions.
10 changes: 8 additions & 2 deletions chrome/browser/ash/accessibility/DEPS
@@ -1,12 +1,18 @@
specific_include_rules = {
# Testing
"accessibility_manager_browsertest.cc": [
".*_browsertest\.cc": [
"+mojo/public",
"+testing/gmock",
"+testing/gtest",
"+ui/events",
"+ui/gfx",
"+ui/views",
"+ui/message_center/message_center.h"
],
"speech_monitor\.(cc|h)": [
"+content/public/browser/tts_controller.h",
],
"accessibility_manager.cc": [
"accessibility_manager\.cc": [
"+services/accessibility/buildflags.h",
],
}

0 comments on commit 4f485e4

Please sign in to comment.