Skip to content

Commit

Permalink
CodeHealth: Remove use of DictionaryValue::empty in /components/sync
Browse files Browse the repository at this point in the history
This change removes the use of DictionaryValue::empty()
and replaces with Value::DictEmpty()

This CL was uploaded by git cl split.

R=rushans@google.com

Bug: 1187020
Change-Id: Idc70cc8b70c8c3adbda45ae7b70808f89b651983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2879652
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Auto-Submit: Fangzhen Song <songfangzhen@bytedance.com>
Reviewed-by: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/master@{#880742}
  • Loading branch information
song-fangzhen authored and Chromium LUCI CQ committed May 8, 2021
1 parent 84329e8 commit 4fb91bd
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions components/sync/js/js_event_details_unittest.cc
Expand Up @@ -17,7 +17,7 @@ class JsEventDetailsTest : public testing::Test {};

TEST_F(JsEventDetailsTest, EmptyList) {
JsEventDetails details;
EXPECT_TRUE(details.Get().empty());
EXPECT_TRUE(details.Get().DictEmpty());
EXPECT_EQ("{}", details.ToString());
}

Expand All @@ -31,7 +31,7 @@ TEST_F(JsEventDetailsTest, FromDictionary) {
JsEventDetails details(&dict);

// |details| should take over |dict|'s data.
EXPECT_TRUE(dict.empty());
EXPECT_TRUE(dict.DictEmpty());
EXPECT_TRUE(details.Get().Equals(&dict_copy));
}

Expand Down

0 comments on commit 4fb91bd

Please sign in to comment.