Privacy Guide: Increase bottom sheet title margin to 16dp

(cherry picked from commit 5ded8b3) Bug: 1451781 Change-Id: I380de457b5a85a327207ea12c45354743caf2ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4594336 Commit-Queue: Rubin Deliallisi <rubindl@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Auto-Submit: Rubin Deliallisi <rubindl@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1153852} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599388 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5790@{#459} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
chromium · Jun 7, 2023 · 508b22e · 508b22e
1 parent ae6eb38
commit 508b22e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/...e/browser/privacy_guide/android/java/res/layout/privacy_guide_sb_enhanced_explanation.xml b/...e/browser/privacy_guide/android/java/res/layout/privacy_guide_sb_enhanced_explanation.xml
@@ -17,8 +17,8 @@ found in the LICENSE file.
         android:orientation="vertical">
 
         <TextView
-            android:drawablePadding="16dp"
-            android:layout_marginVertical="8dp"
+            android:layout_marginTop="@dimen/bottom_sheet_title_marginTop"
+            android:layout_marginBottom="@dimen/bottom_sheet_title_marginBottom"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:text="@string/privacy_guide_safe_browsing_enhanced_title"

diff --git a/...e/browser/privacy_guide/android/java/res/layout/privacy_guide_sb_standard_explanation.xml b/...e/browser/privacy_guide/android/java/res/layout/privacy_guide_sb_standard_explanation.xml
@@ -17,8 +17,8 @@ found in the LICENSE file.
         android:orientation="vertical">
 
         <TextView
-            android:drawablePadding="16dp"
-            android:layout_marginVertical="8dp"
+            android:layout_marginTop="@dimen/bottom_sheet_title_marginTop"
+            android:layout_marginBottom="@dimen/bottom_sheet_title_marginBottom"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:text="@string/privacy_guide_safe_browsing_standard_title"

diff --git a/chrome/browser/privacy_guide/android/java/res/values/dimens.xml b/chrome/browser/privacy_guide/android/java/res/values/dimens.xml
@@ -9,6 +9,8 @@ found in the LICENSE file.
   <dimen name="all_content_marginHorizontal">16dp</dimen>
   <dimen name="explanation_marginVertical">16dp</dimen>
   <dimen name="bottom_bar_marginVertical">8dp</dimen>
+  <dimen name="bottom_sheet_title_marginBottom">8dp</dimen>
+  <dimen name="bottom_sheet_title_marginTop">16dp</dimen>
   <dimen name="done_step_description_marginBottom">16dp</dimen>
   <dimen name="done_step_header_marginBottom">4dp</dimen>
   <dimen name="done_step_illustration_marginHorizontal">16dp</dimen>