Skip to content

Commit

Permalink
Revert "VCD: Move Ash-Chrome only codes under ash/ folder"
Browse files Browse the repository at this point in the history
This reverts commit 3e19bbb.

Reason for revert: We decide not to put CrOS VCD into Lacros Chrome.

Original change's description:
> VCD: Move Ash-Chrome only codes under ash/ folder
>
> This CL does:
>
> 1. Move CameraHalDispatcherImpl under ash/.
> 2. Move PowerManagerClientProxy into a standalone class under ash/.
>
> Bug: b/175168296
> Test: Build successfully
> Change-Id: I60455aa8e593a5654c69af06957c509a26ac8964
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589414
> Reviewed-by: Shik Chen <shik@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Wei Lee <wtlee@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#851072}

Bug: b/175168296
Change-Id: I00fef9b0c9e596bc82e550229e2d3ba712c6f6e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2719781
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Wei Lee <wtlee@chromium.org>
Auto-Submit: Wei Lee <wtlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859086}
  • Loading branch information
Wei Lee authored and Chromium LUCI CQ committed Mar 2, 2021
1 parent 4868a92 commit 531d91e
Show file tree
Hide file tree
Showing 20 changed files with 128 additions and 247 deletions.
2 changes: 1 addition & 1 deletion chrome/browser/chromeos/camera_mic/vm_camera_mic_manager.h
Expand Up @@ -16,7 +16,7 @@
#include "base/observer_list_types.h"
#include "base/scoped_observation.h"
#include "components/keyed_service/core/keyed_service.h"
#include "media/capture/video/chromeos/ash/camera_hal_dispatcher_impl.h"
#include "media/capture/video/chromeos/camera_hal_dispatcher_impl.h"
#include "ui/message_center/public/cpp/notification.h"
#include "ui/message_center/public/cpp/notification_delegate.h"

Expand Down
Expand Up @@ -21,7 +21,7 @@
#include "chromeos/dbus/vm_permission_service/vm_permission_service.pb.h"
#include "components/prefs/pref_service.h"
#include "dbus/message.h"
#include "media/capture/video/chromeos/ash/camera_hal_dispatcher_impl.h"
#include "media/capture/video/chromeos/camera_hal_dispatcher_impl.h"
#include "third_party/cros_system_api/dbus/service_constants.h"

namespace {
Expand Down
2 changes: 1 addition & 1 deletion chrome/browser/ui/ash/media_client_impl.h
Expand Up @@ -14,7 +14,7 @@
#include "chrome/browser/chromeos/camera_mic/vm_camera_mic_manager.h"
#include "chrome/browser/media/webrtc/media_capture_devices_dispatcher.h"
#include "chrome/browser/ui/browser_list_observer.h"
#include "media/capture/video/chromeos/ash/camera_hal_dispatcher_impl.h"
#include "media/capture/video/chromeos/camera_hal_dispatcher_impl.h"
#include "media/capture/video/chromeos/mojom/cros_camera_service.mojom.h"
#include "ui/base/accelerators/media_keys_listener.h"

Expand Down
2 changes: 1 addition & 1 deletion components/arc/camera/DEPS
@@ -1,4 +1,4 @@
include_rules = [
"+crypto/random.h",
"+media/capture/video/chromeos/ash/camera_hal_dispatcher_impl.h",
"+media/capture/video/chromeos/camera_hal_dispatcher_impl.h",
]
2 changes: 1 addition & 1 deletion components/arc/camera/arc_camera_bridge.cc
Expand Up @@ -15,7 +15,7 @@
#include "components/arc/arc_browser_context_keyed_service_factory_base.h"
#include "components/arc/session/arc_bridge_service.h"
#include "crypto/random.h"
#include "media/capture/video/chromeos/ash/camera_hal_dispatcher_impl.h"
#include "media/capture/video/chromeos/camera_hal_dispatcher_impl.h"
#include "mojo/public/cpp/bindings/remote.h"
#include "mojo/public/cpp/platform/platform_channel.h"
#include "mojo/public/cpp/system/invitation.h"
Expand Down
Expand Up @@ -84,7 +84,7 @@
#include "ash/components/audio/cras_audio_handler.h"
#include "content/browser/gpu/chromeos/video_capture_dependencies.h"
#include "content/browser/gpu/gpu_memory_buffer_manager_singleton.h"
#include "media/capture/video/chromeos/ash/camera_hal_dispatcher_impl.h"
#include "media/capture/video/chromeos/camera_hal_dispatcher_impl.h"
#include "media/capture/video/chromeos/public/cros_features.h"
#include "media/capture/video/chromeos/video_capture_device_factory_chromeos.h"
#endif
Expand Down
16 changes: 4 additions & 12 deletions media/capture/BUILD.gn
Expand Up @@ -293,6 +293,8 @@ component("capture_lib") {
"video/chromeos/camera_device_delegate.h",
"video/chromeos/camera_hal_delegate.cc",
"video/chromeos/camera_hal_delegate.h",
"video/chromeos/camera_hal_dispatcher_impl.cc",
"video/chromeos/camera_hal_dispatcher_impl.h",
"video/chromeos/camera_metadata_utils.cc",
"video/chromeos/camera_metadata_utils.h",
"video/chromeos/capture_metadata_dispatcher.h",
Expand Down Expand Up @@ -334,6 +336,7 @@ component("capture_lib") {
deps += [
"//ash/constants",
"//build/config/linux/libdrm",
"//chromeos/dbus/power",
"//components/chromeos_camera:mojo_mjpeg_decode_accelerator",
"//components/chromeos_camera/common",
"//components/device_event_log",
Expand All @@ -343,17 +346,6 @@ component("capture_lib") {
]
}

if (is_chromeos_ash) {
sources += [
"video/chromeos/ash/camera_hal_dispatcher_impl.cc",
"video/chromeos/ash/camera_hal_dispatcher_impl.h",
"video/chromeos/ash/power_manager_client_proxy.cc",
"video/chromeos/ash/power_manager_client_proxy.h",
]

deps += [ "//chromeos/dbus/power" ]
}

if (is_fuchsia) {
sources += [
"video/fuchsia/video_capture_device_factory_fuchsia.cc",
Expand Down Expand Up @@ -550,10 +542,10 @@ test("capture_unittests") {

if (is_chromeos_ash) {
sources += [
"video/chromeos/ash/camera_hal_dispatcher_impl_unittest.cc",
"video/chromeos/camera_3a_controller_unittest.cc",
"video/chromeos/camera_device_delegate_unittest.cc",
"video/chromeos/camera_hal_delegate_unittest.cc",
"video/chromeos/camera_hal_dispatcher_impl_unittest.cc",
"video/chromeos/request_manager_unittest.cc",
"video/chromeos/token_manager_unittest.cc",
]
Expand Down
1 change: 1 addition & 0 deletions media/capture/video/chromeos/DEPS
@@ -1,5 +1,6 @@
include_rules = [
"+ash/constants/ash_features.h",
"+chromeos/dbus",
"+components/chromeos_camera",
"+third_party/libsync",
]
3 changes: 0 additions & 3 deletions media/capture/video/chromeos/ash/DEPS

This file was deleted.

84 changes: 0 additions & 84 deletions media/capture/video/chromeos/ash/power_manager_client_proxy.cc

This file was deleted.

66 changes: 0 additions & 66 deletions media/capture/video/chromeos/ash/power_manager_client_proxy.h

This file was deleted.

2 changes: 1 addition & 1 deletion media/capture/video/chromeos/camera_hal_delegate.cc
Expand Up @@ -23,9 +23,9 @@
#include "base/system/system_monitor.h"
#include "base/unguessable_token.h"
#include "components/device_event_log/device_event_log.h"
#include "media/capture/video/chromeos/ash/camera_hal_dispatcher_impl.h"
#include "media/capture/video/chromeos/camera_app_device_bridge_impl.h"
#include "media/capture/video/chromeos/camera_buffer_factory.h"
#include "media/capture/video/chromeos/camera_hal_dispatcher_impl.h"
#include "media/capture/video/chromeos/camera_metadata_utils.h"
#include "media/capture/video/chromeos/video_capture_device_chromeos_delegate.h"
#include "media/capture/video/chromeos/video_capture_device_chromeos_halv3.h"
Expand Down
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "media/capture/video/chromeos/ash/camera_hal_dispatcher_impl.h"
#include "media/capture/video/chromeos/camera_hal_dispatcher_impl.h"
#include <fcntl.h>
#include <grp.h>
#include <poll.h>
Expand Down
Expand Up @@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#ifndef MEDIA_CAPTURE_VIDEO_CHROMEOS_ASH_CAMERA_HAL_DISPATCHER_IMPL_H_
#define MEDIA_CAPTURE_VIDEO_CHROMEOS_ASH_CAMERA_HAL_DISPATCHER_IMPL_H_
#ifndef MEDIA_CAPTURE_VIDEO_CHROMEOS_CAMERA_HAL_DISPATCHER_IMPL_H_
#define MEDIA_CAPTURE_VIDEO_CHROMEOS_CAMERA_HAL_DISPATCHER_IMPL_H_

#include <memory>
#include <set>
Expand Down Expand Up @@ -280,4 +280,4 @@ class CAPTURE_EXPORT CameraHalDispatcherImpl final

} // namespace media

#endif // MEDIA_CAPTURE_VIDEO_CHROMEOS_ASH_CAMERA_HAL_DISPATCHER_IMPL_H_
#endif // MEDIA_CAPTURE_VIDEO_CHROMEOS_CAMERA_HAL_DISPATCHER_IMPL_H_
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "media/capture/video/chromeos/ash/camera_hal_dispatcher_impl.h"
#include "media/capture/video/chromeos/camera_hal_dispatcher_impl.h"

#include <memory>
#include <utility>
Expand Down

0 comments on commit 531d91e

Please sign in to comment.