Skip to content

Commit

Permalink
[Exo]Add Intel CCS modifiers to the block_list
Browse files Browse the repository at this point in the history
Buffers with CCS modifiers appears to be sometimes transparent on the
first frame. They also have memory leak issues.

(cherry picked from commit 274d900)

Bug: 1458575, 1445252
Change-Id: I58d364b0d35821978d8a15435a817ea44cf2d198
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4657728
Reviewed-by: Peter McNeeley <petermcneeley@chromium.org>
Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1164411}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4658159
Commit-Queue: Peter McNeeley <petermcneeley@chromium.org>
Cr-Commit-Position: refs/branch-heads/5845@{#258}
Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
  • Loading branch information
fangzhoug authored and Chromium LUCI CQ committed Jun 30, 2023
1 parent 7d2e77c commit 553de33
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions components/exo/wayland/wayland_dmabuf_feedback_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -323,12 +323,18 @@ WaylandDmabufFeedbackManager::WaylandDmabufFeedbackManager(Display* display)
base::flat_map<size_t, uint64_t> modifier_entries;
modifier_entries.emplace(format_table_index++, DRM_FORMAT_MOD_INVALID);

// Gen12 intel modifiers leak memory on gbm to gl buffer import. Block these
// modifiers for now. See crbug.com/1445252
// Intel CCS modifiers leak memory on gbm to gl buffer import. Block these
// modifiers for now. See crbug.com/1445252, crbug.com/1458575
const base::flat_set<uint64_t> modifier_block_list = {
I915_FORMAT_MOD_Y_TILED_CCS,
I915_FORMAT_MOD_Yf_TILED_CCS,
I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS,
I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS,
I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC};
I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC,
I915_FORMAT_MOD_4_TILED_DG2_RC_CCS,
I915_FORMAT_MOD_4_TILED_DG2_MC_CCS,
I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC,
};

if (base::FeatureList::IsEnabled(ash::features::kExoLinuxDmabufModifiers)) {
for (uint64_t modifier : modifiers) {
Expand Down

0 comments on commit 553de33

Please sign in to comment.