Feature flag - Web Feed Awareness

This feature flag will be used to enable/disable the code to draw attention to the unread indicator. Bug: b:215796016 Change-Id: Ib04c32ecbf7f03bd8abc42be9fbcc40e2320c169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3579289 Reviewed-by: Dan H <harringtond@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/main@{#990698}
chromium · Apr 9, 2022 · 55cbb16 · 55cbb16
1 parent 9e70384
commit 55cbb16
Show file tree

Hide file tree

Showing 9 changed files with 28 additions and 4 deletions.
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
@@ -4397,6 +4397,9 @@ const FeatureEntry kFeatureEntries[] = {
      FEATURE_WITH_PARAMS_VALUE_TYPE(feed::kWebFeed,
                                     kWebFeedVariations,
                                     "WebFeed")},
+    {"web-feed-awareness", flag_descriptions::kWebFeedAwarenessName,
+     flag_descriptions::kWebFeedAwarenessDescription, kOsAndroid,
+     FEATURE_VALUE_TYPE(feed::kWebFeedAwareness)},
     {"web-feed-onboarding", flag_descriptions::kWebFeedOnboardingName,
      flag_descriptions::kWebFeedOnboardingDescription, kOsAndroid,
      FEATURE_VALUE_TYPE(feed::kWebFeedOnboarding)},

diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
@@ -6012,6 +6012,11 @@
     "owners": [ "//chrome/android/feed/OWNERS", "feed@chromium.org" ],
     "expiry_milestone": 110
   },
+  {
+    "name": "web-feed-awareness",
+    "owners": [ "//chrome/android/feed/OWNERS", "feed@chromium.org" ],
+    "expiry_milestone": 110
+  },
   {
     "name": "web-feed-ios",
     "owners": [ "adamta", "sczs", "tinazwang" ],

diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
@@ -3605,9 +3605,13 @@ const char kWebFeedName[] = "Web Feed";
 const char kWebFeedDescription[] =
     "Allows users to keep up with and consume web content.";
 
+const char kWebFeedAwarenessName[] = "Web Feed Awareness";
+const char kWebFeedAwarenessDescription[] =
+    "Helps the user discover the web feed.";
+
 const char kWebFeedOnboardingName[] = "Web Feed Onboarding";
 const char kWebFeedOnboardingDescription[] =
-    "Helps the user discover and use the web feed.";
+    "Helps the user understand how to use the web feed.";
 
 const char kWebFeedSortName[] = "Web Feed Sort";
 const char kWebFeedSortDescription[] =

diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
@@ -2049,6 +2049,9 @@ extern const char kVoiceButtonInTopToolbarDescription[];
 extern const char kWebFeedName[];
 extern const char kWebFeedDescription[];
 
+extern const char kWebFeedAwarenessName[];
+extern const char kWebFeedAwarenessDescription[];
+
 extern const char kWebFeedOnboardingName[];
 extern const char kWebFeedOnboardingDescription[];
 

diff --git a/chrome/browser/flags/android/chrome_feature_list.cc b/chrome/browser/flags/android/chrome_feature_list.cc
@@ -150,6 +150,7 @@ const base::Feature* const kFeaturesExposedToJava[] = {
     &feed::kInterestFeedV2Hearts,
     &feed::kReliabilityLogging,
     &feed::kWebFeed,
+    &feed::kWebFeedAwareness,
     &feed::kWebFeedOnboarding,
     &feed::kWebFeedSort,
     &feed::kXsurfaceMetricsReporting,

diff --git a/...e/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java b/...e/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
@@ -536,9 +536,10 @@ public static boolean getFieldTrialParamByFeatureAsBoolean(
     public static final String VR_BROWSING_FEEDBACK = "VrBrowsingFeedback";
     public static final String WEB_AUTH_PHONE_SUPPORT = "WebAuthenticationPhoneSupport";
     public static final String WEB_FEED = "WebFeed";
-    public static final String WEBNOTES_DYNAMIC_TEMPLATES = "WebNotesDynamicTemplates";
+    public static final String WEB_FEED_AWARENESS = "WebFeedAwareness";
     public static final String WEB_FEED_ONBOARDING = "WebFeedOnboarding";
     public static final String WEB_FEED_SORT = "WebFeedSort";
+    public static final String WEBNOTES_DYNAMIC_TEMPLATES = "WebNotesDynamicTemplates";
     public static final String WEBNOTES_STYLIZE = "WebNotesStylize";
     public static final String WEB_APK_INSTALL_COMPLETE_NOTIFICATION =
             "WebApkInstallCompleteNotification";

diff --git a/components/feed/feed_feature_list.cc b/components/feed/feed_feature_list.cc
@@ -79,6 +79,9 @@ const base::Feature kFeedStamp{"FeedStamp", base::FEATURE_DISABLED_BY_DEFAULT};
 
 const char kDefaultReferrerUrl[] = "https://www.google.com/";
 
+const base::Feature kWebFeedAwareness{"WebFeedAwareness",
+                                      base::FEATURE_DISABLED_BY_DEFAULT};
+
 const base::Feature kWebFeedOnboarding{"WebFeedOnboarding",
                                        base::FEATURE_DISABLED_BY_DEFAULT};
 

diff --git a/components/feed/feed_feature_list.h b/components/feed/feed_feature_list.h
@@ -85,8 +85,10 @@ extern const base::Feature kFeedBackToTop;
 // Feature that enables StAMP cards in the feed.
 extern const base::Feature kFeedStamp;
 
-// Feature that provides the user assistance in discovering and using the web
-// feed.
+// Feature that provides the user assistance in discovering the web feed.
+extern const base::Feature kWebFeedAwareness;
+
+// Feature that provides the user assistance in using the web feed.
 extern const base::Feature kWebFeedOnboarding;
 
 // Feature that enables sorting by different heuristics in the web feed.

diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
@@ -52033,6 +52033,7 @@ from previous Chrome versions.
   <int value="-2058656447" label="ContextualSearchUrlActions:enabled"/>
   <int value="-2057927571"
       label="AutofillEnableSendingBcnInGetUploadDetails:enabled"/>
+  <int value="-2056436874" label="WebFeedAwareness:disabled"/>
   <int value="-2056351013" label="AutofillUpdatedCardUnmaskPromptUi:enabled"/>
   <int value="-2056198604" label="InterestFeedV2Hearts:disabled"/>
   <int value="-2054871630"
@@ -54637,6 +54638,7 @@ from previous Chrome versions.
   <int value="-329807250" label="EnableNeuralPalmRejectionBetaModel:disabled"/>
   <int value="-329727402" label="disable-files-quick-view"/>
   <int value="-328361990" label="enable-experimental-extension-apis"/>
+  <int value="-328339709" label="WebFeedAwareness:enabled"/>
   <int value="-327520505" label="RelatedSearchesAlternateUx:enabled"/>
   <int value="-327272022" label="AutofillRejectCompanyBirthyearName:enabled"/>
   <int value="-326535569" label="WebNotesStylize:disabled"/>