Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[M118] Remove
CHECK_IS_TEST
that's causing production issues
The `CHECK_IS_TEST` in `TemplateURLService::ApplyDefaultSearchChange` is crashing in production. This was previously a `DCHECK` and was replaced by a `CHECK_IS_TEST` for testing purposes. This will not cause issues because the pointer is never dereferenced. See https://bugs.chromium.org/p/chromium/issues/detail?id=1483111#c7 for further reasoning. (cherry picked from commit 39daf18) Fixed: 1483111, 1491858 Change-Id: Ia36ec84f3d2e85c806c6a83c6b3e5df54a747e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4897116 Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Jack Yammine <jyammine@google.com> Reviewed-by: Jens Mueller <muellerj@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1202391} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4939024 Commit-Queue: Daniel Yip <danielyip@google.com> Auto-Submit: Daniel Yip <danielyip@google.com> Owners-Override: Daniel Yip <danielyip@google.com> Reviewed-by: Jack Yammine <jyammine@google.com> Cr-Commit-Position: refs/branch-heads/5993@{#1296} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
- Loading branch information