Skip to content

Commit

Permalink
[m115][omnibox][cr23] Fix pdf test for SS height.
Browse files Browse the repository at this point in the history
m115 merge.

crrev.com/c/4581107 launched omnibox SS height, increasing the omnibox
height from 28px to 34px.

This decreased the height available for page contents.
`PDFExtensionJSTest.AnnotationsFeatureEnabled` is sensitive to the
height, so it began failing.

This CL adjusts its expectations to pass with the SS height launch. I
think the test is rendering a PDF dialog then measuring the location of
some items. It seems reasonable that the location of things moves when
the available height decreases. I simply updated the expectations to
match the new positions. But I didn't actually verify the correctness of
the new values.

(cherry picked from commit 1438740)

Bug: 1368852, 1454196, 1416351
Change-Id: I2faeedf1e93b0204cd461b5b26df30be6d3bb355
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608577
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1157046}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4610822
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5790@{#715}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
  • Loading branch information
manukh authored and Chromium LUCI CQ committed Jun 13, 2023
1 parent e108ff2 commit 5727c1d
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions chrome/test/data/pdf/annotations_feature_enabled_test.ts
Expand Up @@ -72,8 +72,8 @@ chrome.test.runTests([
dark_light_left: -105.75,
right: 718.5,
dark_light_right: 717.75,
bottom: -412.5,
dark_light_bottom: -411.75,
bottom: -408.75,
dark_light_bottom: -408.0,
},
{
top: 2.25,
Expand All @@ -82,8 +82,8 @@ chrome.test.runTests([
dark_light_left: -3.75,
right: 408.75,
dark_light_right: 408,
bottom: -205.125,
dark_light_bottom: -204.75,
bottom: -203.25,
dark_light_bottom: -202.875,
},
{
top: -35.25,
Expand All @@ -92,8 +92,8 @@ chrome.test.runTests([
dark_light_left: 33.75,
right: 446.25,
dark_light_right: 445.5,
bottom: -242.625,
dark_light_bottom: -242.25,
bottom: -240.75,
dark_light_bottom: -240.375,
},
];

Expand Down

0 comments on commit 5727c1d

Please sign in to comment.