Skip to content

Commit

Permalink
[base] Skip OutputToStream checks in Fuchsia Official builds.
Browse files Browse the repository at this point in the history
StackTrace has a bug preventing it from capturing any stack frames in
Fuchsia Official builds, so disable those checks for now.

TBR=ajwong

(cherry picked from commit eaf1553)

Bug: 1025329, 1025288
Change-Id: I2b24c7f903c345518835edc3226b15355ea1bf9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919735
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#715875}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919811
Reviewed-by: Srinivas Sista <srinivassista@chromium.org>
Cr-Commit-Position: refs/branch-heads/3968@{#4}
Cr-Branched-From: 7b5a22c-refs/heads/master@{#715511}
  • Loading branch information
Wez authored and Srinivas Sista committed Nov 15, 2019
1 parent 019f515 commit 57c991b
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions base/debug/stack_trace_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@ TEST_F(StackTraceTest, OutputToStream) {
return;
#endif // defined(OFFICIAL_BUILD) && defined(OS_POSIX) && !defined(OS_MACOSX)

#if defined(OFFICIAL_BUILD) && defined(OS_FUCHSIA)
// TODO(https://crbug.com/1025329): StackTrace fails to capture any frames in
// Fuchsia Official builds.
return;
#endif // defined(OFFICIAL_BUILD) && defined(OS_FUCHSIA)

ASSERT_TRUE(addresses);
ASSERT_GT(frames_found, 5u) << "Too few frames found.";

Expand Down

0 comments on commit 57c991b

Please sign in to comment.