Skip to content

Commit

Permalink
[v8][wasm] Add blink flag for Turboshaft wasm compilation
Browse files Browse the repository at this point in the history
Bug: chromium:1496282
Change-Id: I39d29f4ab0be5298b41dd20c8b184eb89a6b36d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4976910
Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1216538}
  • Loading branch information
manoskouk authored and Chromium LUCI CQ committed Oct 28, 2023
1 parent 002c408 commit 582a5b7
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
4 changes: 4 additions & 0 deletions gin/gin_features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -268,4 +268,8 @@ BASE_FEATURE(kWebAssemblyMultipleMemories,
"WebAssemblyMultipleMemories",
base::FEATURE_ENABLED_BY_DEFAULT);

BASE_FEATURE(kWebAssemblyTurboshaft,
"WebAssemblyTurboshaft",
base::FEATURE_DISABLED_BY_DEFAULT);

} // namespace features
1 change: 1 addition & 0 deletions gin/gin_features.h
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ GIN_EXPORT BASE_DECLARE_FEATURE(kWebAssemblyTailCall);
GIN_EXPORT BASE_DECLARE_FEATURE(kWebAssemblyInlining);
GIN_EXPORT BASE_DECLARE_FEATURE(kWebAssemblyGenericWrapper);
GIN_EXPORT BASE_DECLARE_FEATURE(kWebAssemblyMultipleMemories);
GIN_EXPORT BASE_DECLARE_FEATURE(kWebAssemblyTurboshaft);

} // namespace features

Expand Down
2 changes: 2 additions & 0 deletions gin/v8_initializer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,8 @@ void SetFlags(IsolateHolder::ScriptMode mode,
SetV8FlagsIfOverridden(features::kWebAssemblyMultipleMemories,
"--experimental-wasm-multi-memory",
"--no-experimental-wasm-multi-memory");
SetV8FlagsIfOverridden(features::kWebAssemblyTurboshaft, "--turboshaft-wasm",
"--no-turboshaft-wasm");

if (js_command_line_flags.empty())
return;
Expand Down

0 comments on commit 582a5b7

Please sign in to comment.