Skip to content

Commit

Permalink
Disable CheckDrawFunctorThread feature flag
Browse files Browse the repository at this point in the history
The feature introduced CHECK to catch wrong treading due to android
platform bug. During rolling M114 out we want to make sure, that while
it does make sure we're in consistent state, we also don't significantly
increase crash rate.

So far crash rate looks reasonable, but in case we need to use kill
switch, disable feature on trunk to de-risk it. Will revert this CL
once M114 rollout will finish (or cherry-pick it to 114, 115 if crash
rate spike will occur).

(cherry picked from commit a92c5ea)

Bug: 1441879
Change-Id: I11e348a5ddedadd671762eddfded868254a67ac4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4568594
Reviewed-by: Saifuddin Hitawala <hitawala@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1149860}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605794
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Prudhvikumar Bommana <pbommana@google.com>
Owners-Override: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/5790@{#543}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
  • Loading branch information
vasilyt authored and Chromium LUCI CQ committed Jun 9, 2023
1 parent ed81c90 commit 5ab580a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion android_webview/browser/gfx/aw_draw_fn_impl.cc
Expand Up @@ -30,7 +30,7 @@ namespace {

BASE_FEATURE(kCheckDrawFunctorThread,
"CheckDrawFunctorThread",
base::FEATURE_ENABLED_BY_DEFAULT);
base::FEATURE_DISABLED_BY_DEFAULT);

// Set once during process-wide initialization.
AwDrawFnFunctionTable* g_draw_fn_function_table = nullptr;
Expand Down

0 comments on commit 5ab580a

Please sign in to comment.