Skip to content

Commit

Permalink
[SharingHub] Adjust QR code option label
Browse files Browse the repository at this point in the history
Change QR code label to "Create QR Code"

Fixed: 1268485
Change-Id: I8e5b285c885d4bbb90ec67e1df090223ece23dca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3586384
Commit-Queue: Kristi Park <kristipark@chromium.org>
Auto-Submit: Kristi Park <kristipark@chromium.org>
Reviewed-by: Travis Skare <skare@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/main@{#992738}
  • Loading branch information
Kristi Park authored and Chromium LUCI CQ committed Apr 14, 2022
1 parent 11bb79b commit 5b4d945
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
3 changes: 3 additions & 0 deletions chrome/app/generated_resources.grd
Original file line number Diff line number Diff line change
Expand Up @@ -8769,6 +8769,9 @@ Keep your key file in a safe place. You will need it to create new versions of y
desc="Title for the QR Generator dialog.">
Scan QR Code
</message>
<message name="IDS_SHARING_HUB_GENERATE_QR_CODE_LABEL" desc="The label for the Create QR Code option in the sharing hub menu.">
Create QR Code
</message>
<message name="IDS_BROWSER_SHARING_QR_CODE_DIALOG_URL_TEXTFIELD_ACCESSIBLE_NAME"
desc="Text to be spoken for the QR Code Generator's URL Textfield.">
URL
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
4056a9de4379476e27291b93b76afddd331446f6
2 changes: 1 addition & 1 deletion chrome/browser/sharing_hub/sharing_hub_model.cc
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ void SharingHubModel::PopulateFirstPartyActions() {

first_party_action_list_.push_back(
{IDC_QRCODE_GENERATOR,
l10n_util::GetStringUTF16(IDS_OMNIBOX_QRCODE_GENERATOR_ICON_LABEL),
l10n_util::GetStringUTF16(IDS_SHARING_HUB_GENERATE_QR_CODE_LABEL),
&kQrcodeGeneratorIcon, true, gfx::ImageSkia(),
"SharingHubDesktop.QRCodeSelected"});

Expand Down

0 comments on commit 5b4d945

Please sign in to comment.