[M91 merge]CrOS: Pass app_id string as const reference in GetBadgeCol…

…orForApp

(cherry picked from commit 4025fda)

Bug: 1132117
Change-Id: I7aaa6d1b267e9d7085a5ab1dd2a3fa93145a4702
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2815834
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#870767}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2822968
Cr-Commit-Position: refs/branch-heads/4472@{#22}
Cr-Branched-From: 3d60439-refs/heads/master@{#870763}

chrome/browser/ui/ash/notification_badge_color_cache.cc

@@ -49,8 +49,9 @@ NotificationBadgeColorCache::NotificationBadgeColorCache() = default;
 
 NotificationBadgeColorCache::~NotificationBadgeColorCache() = default;
 
-SkColor NotificationBadgeColorCache::GetBadgeColorForApp(std::string app_id,
-                                                         gfx::ImageSkia icon) {
+SkColor NotificationBadgeColorCache::GetBadgeColorForApp(
+    const std::string& app_id,
+    gfx::ImageSkia icon) {
   AppIdBadgeColor::const_iterator it = app_id_badge_color_map_.find(app_id);
   if (it != app_id_badge_color_map_.end())
     return it->second;

chrome/browser/ui/ash/notification_badge_color_cache.h

@@ -30,7 +30,7 @@ class NotificationBadgeColorCache {
 
   // Calculate the color for the notification badge and cache it. If the
   // |app_id| already has a cached color then return that instead.
-  SkColor GetBadgeColorForApp(std::string app_id, gfx::ImageSkia icon);
+  SkColor GetBadgeColorForApp(const std::string& app_id, gfx::ImageSkia icon);
 
  private:
   using AppIdBadgeColor = std::map<std::string, SkColor>;