Skip to content

Commit

Permalink
[M90-LTS] serial: Fix parent class tracing for SerialPort
Browse files Browse the repository at this point in the history
When SerialPort was updated to be ActiveScriptWrappable and an
EventTarget the Trace method was not updated to call the parent class
trace methods.

(cherry picked from commit 4059ecc)

Bug: 1220078
Change-Id: If6967a913268bce86d4488359a9418a814530f84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2965255
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#893039}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3041456
Reviewed-by: Jana Grill <janagrill@google.com>
Owners-Override: Jana Grill <janagrill@google.com>
Commit-Queue: Roger Felipe Zanoni da Silva <rzanoni@google.com>
Cr-Commit-Position: refs/branch-heads/4430@{#1541}
Cr-Branched-From: e5ce7dc-refs/heads/master@{#857950}
  • Loading branch information
reillyeon authored and Chromium LUCI CQ committed Jul 27, 2021
1 parent c507623 commit 62ba4b5
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion third_party/blink/renderer/modules/serial/serial_port.cc
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,8 @@ void SerialPort::Trace(Visitor* visitor) const {
visitor->Trace(open_resolver_);
visitor->Trace(signal_resolvers_);
visitor->Trace(close_resolver_);
ScriptWrappable::Trace(visitor);
EventTargetWithInlineData::Trace(visitor);
ActiveScriptWrappable<SerialPort>::Trace(visitor);
}

bool SerialPort::HasPendingActivity() const {
Expand Down

0 comments on commit 62ba4b5

Please sign in to comment.