Skip to content

Commit

Permalink
[gardener] disable failing ExtensionCrashRecoveryTest tests
Browse files Browse the repository at this point in the history
The following two tests are failing on chromium/ci/Linux Tests (Wayland)
because of timeout.
- ExtensionCrashRecoveryTest.Basic
- ExtensionCrashRecoveryTest.ReloadIndependentlyNavigatePage

See https://ci.chromium.org/ui/b/8770044050641141505

(cherry picked from commit ab9c904)

Bug: 1482434
Change-Id: I07f1cdf6a5297bb9573dd0880b943aece2e67353
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4864558
Auto-Submit: Keren Zhu <kerenzhu@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1196314}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4906624
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Owners-Override: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
Auto-Submit: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/branch-heads/5993@{#1058}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
  • Loading branch information
naeioi authored and Chromium LUCI CQ committed Oct 2, 2023
1 parent 999b33a commit 639d3bc
Showing 1 changed file with 15 additions and 2 deletions.
17 changes: 15 additions & 2 deletions chrome/browser/extensions/extension_crash_recovery_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,13 @@ class ExtensionCrashRecoveryTest : public extensions::ExtensionBrowserTest {
content::ScopedAllowRendererCrashes scoped_allow_renderer_crashes_;
};

IN_PROC_BROWSER_TEST_F(ExtensionCrashRecoveryTest, Basic) {
// TODO(crbug.com/1482434): timeout on wayland.
#if BUILDFLAG(IS_LINUX) && defined(OZONE_PLATFORM_WAYLAND)
#define MAYBE_Basic DISABLED_Basic
#else
#define MAYBE_Basic Basic
#endif
IN_PROC_BROWSER_TEST_F(ExtensionCrashRecoveryTest, MAYBE_Basic) {
const size_t count_before = GetEnabledExtensionCount();
const size_t crash_count_before = GetTerminatedExtensionCount();
LoadTestExtension();
Expand Down Expand Up @@ -229,8 +235,15 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrashRecoveryTest,
ASSERT_EQ(0U, CountNotifications());
}

// TODO(crbug.com/1482434): timeout on wayland.
#if BUILDFLAG(IS_LINUX) && defined(OZONE_PLATFORM_WAYLAND)
#define MAYBE_ReloadIndependentlyNavigatePage \
DISABLED_ReloadIndependentlyNavigatePage
#else
#define MAYBE_ReloadIndependentlyNavigatePage ReloadIndependentlyNavigatePage
#endif
IN_PROC_BROWSER_TEST_F(ExtensionCrashRecoveryTest,
ReloadIndependentlyNavigatePage) {
MAYBE_ReloadIndependentlyNavigatePage) {
const size_t count_before = GetEnabledExtensionCount();
LoadTestExtension();
CrashExtension(first_extension_id_);
Expand Down

0 comments on commit 639d3bc

Please sign in to comment.