-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[M116][UPMLocalPwd] Start the export flow
Clicking on the Next button on the sheet starts the export flow and leaves the sheet open in the background because the fragment owning the flow must stay present during the export. The sheet will be closed in a follow-up CL. (cherry picked from commit 0dea59e) Bug: 1445065 Change-Id: Iee44ec57eca877af547680cb1a6fdd5757794778 Low-Coverage-Reason: not useful (this is plumbing code) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614480 Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Ivana Žužić <izuzic@google.com> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by: Ioana Pandele <ioanap@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1161793} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4641935 Commit-Queue: Ivana Žužić <izuzic@google.com> Cr-Commit-Position: refs/branch-heads/5845@{#84} Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
- Loading branch information
Ivana Žužić
authored and
Chromium LUCI CQ
committed
Jun 26, 2023
1 parent
26307bd
commit 67db02e
Showing
17 changed files
with
230 additions
and
101 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
.../java/src/org/chromium/chrome/browser/password_manager/settings/PasswordListObserver.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| // Copyright 2023 The Chromium Authors | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| package org.chromium.chrome.browser.password_manager.settings; | ||
|
|
||
| /** | ||
| * An interface which a client can use to listen to changes to password and password exception | ||
| * lists. | ||
| */ | ||
| public interface PasswordListObserver { | ||
| /** | ||
| * Called when passwords list is updated. | ||
| * | ||
| * @param count Number of entries in the password list. | ||
| */ | ||
| void passwordListAvailable(int count); | ||
|
|
||
| /** | ||
| * Called when password exceptions list is updated. | ||
| * | ||
| * @param count Number of entries in the password exception list. | ||
| */ | ||
| void passwordExceptionListAvailable(int count); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
...pwd_migration/java/src/org/chromium/chrome/browser/pwd_migration/ExportFlowInterface.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // Copyright 2023 The Chromium Authors | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| package org.chromium.chrome.browser.pwd_migration; | ||
|
|
||
| import android.app.Activity; | ||
| import android.os.Bundle; | ||
|
|
||
| import androidx.fragment.app.FragmentManager; | ||
|
|
||
| /** | ||
| * An interface for the implementations of {@link ExportFlow}. | ||
| */ | ||
| public interface ExportFlowInterface { | ||
| /** The delegate to provide ExportFlow with essential information from the owning fragment. */ | ||
| public interface Delegate { | ||
| /** | ||
| * @return The activity associated with the owning fragment. | ||
| */ | ||
| Activity getActivity(); | ||
|
|
||
| /** | ||
| * @return The fragment manager associated with the owning fragment. | ||
| */ | ||
| FragmentManager getFragmentManager(); | ||
|
|
||
| /** | ||
| * @return The ID of the root view of the owning fragment. | ||
| */ | ||
| int getViewId(); | ||
| } | ||
|
|
||
| /** | ||
| * A hook to be used in the onCreate method of the owning {@link Fragment}. I restores the state | ||
| * of the flow. | ||
| * | ||
| * @param savedInstanceState The {@link Bundle} passed from the fragment's onCreate | ||
| * method. | ||
| * @param delegate The {@link Delegate} for this ExportFlow. | ||
| */ | ||
| public void onCreate(Bundle savedInstanceState, Delegate delegate); | ||
|
|
||
| /** | ||
| * Starts the password export flow. | ||
| */ | ||
| public void startExporting(); | ||
|
|
||
| /** | ||
| * A hook to be used in a {@link Fragment}'s onResume method. I processes the result of the | ||
| * reauthentication. | ||
| */ | ||
| public void onResume(); | ||
| } |
Oops, something went wrong.