Skip to content

Commit

Permalink
Gardending: Disable flaky TestReadingListEventsAcrossProfiles on Mac
Browse files Browse the repository at this point in the history
(cherry picked from commit a9dff3d)

Bug: 1482646
Change-Id: I0706896f25e1fbfded3792fd5eafbefcda4c5b77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4866058
Auto-Submit: Mingyu Lei <leimy@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Mingyu Lei <leimy@chromium.org>
Owners-Override: Mingyu Lei <leimy@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1196637}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4913632
Auto-Submit: Joseph Park <josephjoopark@chromium.org>
Reviewed-by: David Pennington <dpenning@chromium.org>
Commit-Queue: Joseph Park <josephjoopark@chromium.org>
Owners-Override: Joseph Park <josephjoopark@chromium.org>
Cr-Commit-Position: refs/branch-heads/5993@{#1233}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
  • Loading branch information
lozy219 authored and Chromium LUCI CQ committed Oct 10, 2023
1 parent bf9ef62 commit 68af620
Showing 1 changed file with 9 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,16 @@ IN_PROC_BROWSER_TEST_F(ReadingListApiTest, TestReadingListWorks) {
ASSERT_TRUE(RunExtensionTest("reading_list")) << message_;
}

// TODO(crbug.com/1482646): Re-enable this test
#if BUILDFLAG(IS_MAC)
#define MAYBE_TestReadingListEventsAcrossProfiles \
DISABLED_TestReadingListEventsAcrossProfiles
#else
#define MAYBE_TestReadingListEventsAcrossProfiles \
TestReadingListEventsAcrossProfiles
#endif // BUILDFLAG(IS_MAC)
IN_PROC_BROWSER_TEST_F(ReadingListApiTest,
TestReadingListEventsAcrossProfiles) {
MAYBE_TestReadingListEventsAcrossProfiles) {
// The EventRouter is shared between on- and off-the-record profiles, so
// this observer will catch events for each.
TestEventRouterObserver event_observer(EventRouter::Get(profile()));
Expand Down

0 comments on commit 68af620

Please sign in to comment.