Skip to content

Commit

Permalink
[WebEngine] Enable browsertests for WebEngine
Browse files Browse the repository at this point in the history
- Disabled tests that currently fail
- Run tests locally via:
 `autoninja -C $BUILD_DIR weblayer_browsertests && $BUILD_DIR/bin/run_weblayer_browsertests
- Tests do not run on CQ yet.


Bug: 1404980
Change-Id: If1b5455e5764f5cb01ea4c3a7a8e047b7ec787e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4278167
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Susanne Westphal <swestphal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1108847}
  • Loading branch information
s-westphal authored and Chromium LUCI CQ committed Feb 23, 2023
1 parent 6474764 commit 69c9a3a
Show file tree
Hide file tree
Showing 30 changed files with 135 additions and 172 deletions.
1 change: 1 addition & 0 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ group("gn_all") {
deps += [
"//weblayer/browser/android/javatests:webengine_support_instrumentation_test_apk",
"//weblayer/browser/java:weblayer_junit_tests",
"//weblayer/test:weblayer_browsertests",
]
}

Expand Down
2 changes: 1 addition & 1 deletion weblayer/browser/ad_tagging_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class AdTaggingBrowserTest : public SubresourceFilterBrowserTest {
};

IN_PROC_BROWSER_TEST_F(AdTaggingBrowserTest,
AdContentSettingAllowed_AdTaggingDisabled) {
DISABLED_AdContentSettingAllowed_AdTaggingDisabled) {
HostContentSettingsMapFactory::GetForBrowserContext(
web_contents()->GetBrowserContext())
->SetDefaultContentSetting(ContentSettingsType::ADS,
Expand Down
8 changes: 4 additions & 4 deletions weblayer/browser/android/metrics/ukm_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,15 @@ IN_PROC_BROWSER_TEST_F(UkmBrowserTest, UserConsentButNotEnabled) {
}

// UKMs are only enabled when there's user consent and it's explicitly enabled.
IN_PROC_BROWSER_TEST_F(UkmBrowserTest, Enabled) {
IN_PROC_BROWSER_TEST_F(UkmBrowserTest, DISABLED_Enabled) {
ukm::UkmTestHelper ukm_test_helper(GetUkmService());

GetProfile()->SetBooleanSetting(SettingType::UKM_ENABLED, true);
EXPECT_TRUE(ukm_test_helper.IsRecordingEnabled());
}

// If UKMs are disabled it's reflected accordingly.
IN_PROC_BROWSER_TEST_F(UkmBrowserTest, EnabledThenDisable) {
IN_PROC_BROWSER_TEST_F(UkmBrowserTest, DISABLED_EnabledThenDisable) {
ukm::UkmTestHelper ukm_test_helper(GetUkmService());

GetProfile()->SetBooleanSetting(SettingType::UKM_ENABLED, true);
Expand All @@ -69,7 +69,7 @@ IN_PROC_BROWSER_TEST_F(UkmBrowserTest, EnabledThenDisable) {
}

// Make sure that UKM is disabled while an incognito profile is alive.
IN_PROC_BROWSER_TEST_F(UkmBrowserTest, RegularPlusIncognitoCheck) {
IN_PROC_BROWSER_TEST_F(UkmBrowserTest, DISABLED_RegularPlusIncognitoCheck) {
ukm::UkmTestHelper ukm_test_helper(GetUkmService());

GetProfile()->SetBooleanSetting(SettingType::UKM_ENABLED, true);
Expand Down Expand Up @@ -100,7 +100,7 @@ IN_PROC_BROWSER_TEST_F(UkmBrowserTest, RegularPlusIncognitoCheck) {
}

// Make sure creating a real profile after Incognito doesn't enable UKM.
IN_PROC_BROWSER_TEST_F(UkmBrowserTest, IncognitoPlusRegularCheck) {
IN_PROC_BROWSER_TEST_F(UkmBrowserTest, DISABLED_IncognitoPlusRegularCheck) {
ukm::UkmTestHelper ukm_test_helper(GetUkmService());

GetProfile()->SetBooleanSetting(SettingType::UKM_ENABLED, true);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ IN_PROC_BROWSER_TEST_F(BackgroundSyncBrowserTest, ContentSettings) {
EXPECT_FALSE(controller->IsOriginTracked(origin));
}

IN_PROC_BROWSER_TEST_F(BackgroundSyncBrowserTest, NormalProfile) {
IN_PROC_BROWSER_TEST_F(BackgroundSyncBrowserTest, DISABLED_NormalProfile) {
// TODO(crbug.com/1087486, 1091211): Make this use
// BackgroundSyncController::ScheduleBrowserWakeup() once we support waking
// the browser up.
Expand Down
5 changes: 3 additions & 2 deletions weblayer/browser/clipboard_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class ClipboardBrowserTest : public WebLayerBrowserTest {
std::unique_ptr<content::ScopedPageFocusOverride> scoped_focus_;
};

IN_PROC_BROWSER_TEST_F(ClipboardBrowserTest, ReadTextSuccess) {
IN_PROC_BROWSER_TEST_F(ClipboardBrowserTest, DISABLED_ReadTextSuccess) {
prompt_factory()->set_response_type(
permissions::PermissionRequestManager::ACCEPT_ALL);
ExecuteScriptWithUserGesture(shell()->tab(), "tryClipboardReadText()");
Expand All @@ -91,7 +91,8 @@ IN_PROC_BROWSER_TEST_F(ClipboardBrowserTest, WriteSanitizedTextSuccess) {
EXPECT_EQ(0, prompt_factory()->TotalRequestCount());
}

IN_PROC_BROWSER_TEST_F(ClipboardBrowserTest, ReadTextWithoutPermission) {
IN_PROC_BROWSER_TEST_F(ClipboardBrowserTest,
DISABLED_ReadTextWithoutPermission) {
prompt_factory()->set_response_type(
permissions::PermissionRequestManager::DENY_ALL);
ExecuteScriptWithUserGesture(shell()->tab(), "tryClipboardReadText()");
Expand Down
17 changes: 3 additions & 14 deletions weblayer/browser/cookie_manager_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -126,13 +126,8 @@ IN_PROC_BROWSER_TEST_F(CookieManagerBrowserTest,
}
}

#if BUILDFLAG(IS_WIN)
// TODO(crbug.com/1204901): Disabled due to flakiness on Windows.
#define MAYBE_FlushCookiesAfterSet DISABLED_FlushCookiesAfterSet
#else
#define MAYBE_FlushCookiesAfterSet FlushCookiesAfterSet
#endif
IN_PROC_BROWSER_TEST_F(CookieManagerBrowserTest, MAYBE_FlushCookiesAfterSet) {
IN_PROC_BROWSER_TEST_F(CookieManagerBrowserTest,
DISABLED_FlushCookiesAfterSet) {
EXPECT_TRUE(embedded_test_server()->Start());
NavigateAndWaitForCompletion(
embedded_test_server()->GetURL("/simple_page.html"), shell());
Expand All @@ -147,14 +142,8 @@ IN_PROC_BROWSER_TEST_F(CookieManagerBrowserTest, MAYBE_FlushCookiesAfterSet) {
EXPECT_GT(GetCookieDbModifiedTime(), original_modified_time);
}

#if BUILDFLAG(IS_WIN)
// TODO(crbug.com/1204901): Disabled due to flakiness on Windows.
#define MAYBE_FlushCookiesAfterSetMultiple DISABLED_FlushCookiesAfterSetMultiple
#else
#define MAYBE_FlushCookiesAfterSetMultiple FlushCookiesAfterSetMultiple
#endif
IN_PROC_BROWSER_TEST_F(CookieManagerBrowserTest,
MAYBE_FlushCookiesAfterSetMultiple) {
DISABLED_FlushCookiesAfterSetMultiple) {
EXPECT_TRUE(embedded_test_server()->Start());
NavigateAndWaitForCompletion(
embedded_test_server()->GetURL("/simple_page.html"), shell());
Expand Down
12 changes: 3 additions & 9 deletions weblayer/browser/download_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ IN_PROC_BROWSER_TEST_F(DownloadBrowserTest, InterceptNoDownload) {
EXPECT_EQ(download_dropped_count(), 1);
}

IN_PROC_BROWSER_TEST_F(DownloadBrowserTest, Basic) {
IN_PROC_BROWSER_TEST_F(DownloadBrowserTest, DISABLED_Basic) {
GURL url(embedded_test_server()->GetURL("/content-disposition.html"));

shell()->tab()->GetNavigationController()->Navigate(url);
Expand Down Expand Up @@ -287,13 +287,7 @@ IN_PROC_BROWSER_TEST_F(DownloadBrowserTest, Cancel) {
EXPECT_EQ(download_state(), DownloadError::kCancelled);
}

// TODO(crbug.com/1314060): Flaky on Windows and Linux.
#if BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_WIN)
#define MAYBE_PauseResume DISABLED_PauseResume
#else
#define MAYBE_PauseResume PauseResume
#endif
IN_PROC_BROWSER_TEST_F(DownloadBrowserTest, MAYBE_PauseResume) {
IN_PROC_BROWSER_TEST_F(DownloadBrowserTest, DISABLED_PauseResume) {
// Add an initial navigation to avoid the tab being deleted if the first
// navigation is a download, since we use the tab for convenience in the
// lambda.
Expand Down Expand Up @@ -328,7 +322,7 @@ IN_PROC_BROWSER_TEST_F(DownloadBrowserTest, MAYBE_PauseResume) {
EXPECT_EQ(download_dropped_count(), 0);
}

IN_PROC_BROWSER_TEST_F(DownloadBrowserTest, NetworkError) {
IN_PROC_BROWSER_TEST_F(DownloadBrowserTest, DISABLED_NetworkError) {
set_failed_callback(base::BindLambdaForTesting([](Download* download) {
CHECK_EQ(download->GetState(), DownloadState::kFailed);
}));
Expand Down
2 changes: 1 addition & 1 deletion weblayer/browser/errorpage_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class ErrorPageReloadBrowserTest : public ErrorPageBrowserTest {
disable_auto_reload =
std::make_unique<DisableAutoReload>(navigation_controller);
navigation_controller->Navigate(url, params);
navigation.WaitForNavigationFinished();
EXPECT_TRUE(navigation.WaitForNavigationFinished());
return navigation.was_successful();
}

Expand Down
3 changes: 2 additions & 1 deletion weblayer/browser/favicon/favicon_fetcher_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ IN_PROC_BROWSER_TEST_F(FaviconFetcherBrowserTest, Basic) {
EXPECT_EQ(2, fetcher_delegate.on_favicon_changed_call_count());
}

IN_PROC_BROWSER_TEST_F(FaviconFetcherBrowserTest, NavigateToPageWithNoFavicon) {
IN_PROC_BROWSER_TEST_F(FaviconFetcherBrowserTest,
DISABLED_NavigateToPageWithNoFavicon) {
ASSERT_TRUE(embedded_test_server()->Start());
TestFaviconFetcherDelegate fetcher_delegate;
auto fetcher = shell()->tab()->CreateFaviconFetcher(&fetcher_delegate);
Expand Down
3 changes: 2 additions & 1 deletion weblayer/browser/navigation_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -944,7 +944,8 @@ class NavigationBrowserTest2 : public NavigationBrowserTest {

// This test verifies the embedder can replace the X-Client-Data header that
// is also set by //components/variations.
IN_PROC_BROWSER_TEST_F(NavigationBrowserTest2, ReplaceXClientDataHeader) {
IN_PROC_BROWSER_TEST_F(NavigationBrowserTest2,
DISABLED_ReplaceXClientDataHeader) {
std::unique_ptr<base::RunLoop> run_loop = std::make_unique<base::RunLoop>();
std::string last_header_value;
auto main_task_runner = base::SequencedTaskRunner::GetCurrentDefault();
Expand Down
4 changes: 3 additions & 1 deletion weblayer/browser/navigation_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,9 @@ const net::HttpResponseHeaders* NavigationImpl::GetResponseHeaders() {

std::string NavigationImpl::GetNormalizedHeader(const std::string& name) {
std::string header_value;
GetResponseHeaders()->GetNormalizedHeader(name, &header_value);
if (GetResponseHeaders()) {
GetResponseHeaders()->GetNormalizedHeader(name, &header_value);
}
return header_value;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,39 +131,23 @@ IN_PROC_BROWSER_TEST_F(NoStatePrefetchBrowserTest,

// Test that adding a link-rel prerender tag causes a fetch.
IN_PROC_BROWSER_TEST_F(NoStatePrefetchBrowserTest,
LinkRelPrerenderPageFetched) {
DISABLED_LinkRelPrerenderPageFetched) {
NavigateAndWaitForCompletion(GURL(https_server_->GetURL("/parent_page.html")),
shell());
prerendered_page_fetched_->Run();
}

// Test that only render blocking resources are loaded during NoStatePrefetch.
// TODO(https://crbug.com/1144282): Fix failures on Asan.
#if defined(ADDRESS_SANITIZER)
#define MAYBE_NSPLoadsRenderBlockingResource \
DISABLED_NSPLoadsRenderBlockingResource
#else
#define MAYBE_NSPLoadsRenderBlockingResource NSPLoadsRenderBlockingResource
#endif
IN_PROC_BROWSER_TEST_F(NoStatePrefetchBrowserTest,
MAYBE_NSPLoadsRenderBlockingResource) {
DISABLED_NSPLoadsRenderBlockingResource) {
NavigateAndWaitForCompletion(GURL(https_server_->GetURL("/parent_page.html")),
shell());
script_resource_fetched_->Run();
EXPECT_EQ("prefetch", purpose_header_value_);
EXPECT_FALSE(script_executed_);
}

// Test that navigating to a no-state-prefetched page executes JS and reuses
// prerendered resources.
// TODO(https://crbug.com/1144282): Fix failures on Asan.
#if defined(ADDRESS_SANITIZER)
#define MAYBE_NavigateToPrerenderedPage DISABLED_NavigateToPrerenderedPage
#else
#define MAYBE_NavigateToPrerenderedPage NavigateToPrerenderedPage
#endif
IN_PROC_BROWSER_TEST_F(NoStatePrefetchBrowserTest,
MAYBE_NavigateToPrerenderedPage) {
DISABLED_NavigateToPrerenderedPage) {
NavigateAndWaitForCompletion(GURL(https_server_->GetURL("/parent_page.html")),
shell());
script_resource_fetched_->Run();
Expand Down Expand Up @@ -205,7 +189,7 @@ IN_PROC_BROWSER_TEST_F(NoStatePrefetchBrowserTest, DISABLED_UKMRecorded) {

// link-rel="prerender" happens even when NoStatePrefetch has been disabled.
IN_PROC_BROWSER_TEST_F(NoStatePrefetchBrowserTest,
LinkRelPrerenderWithNSPDisabled) {
DISABLED_LinkRelPrerenderWithNSPDisabled) {
GetProfile()->SetBooleanSetting(SettingType::NETWORK_PREDICTION_ENABLED,
false);
NavigateAndWaitForCompletion(GURL(https_server_->GetURL("/parent_page.html")),
Expand All @@ -227,7 +211,7 @@ IN_PROC_BROWSER_TEST_F(NoStatePrefetchBrowserTest, LinkRelNextWithNSPDisabled) {
#if defined(ADDRESS_SANITIZER)
#define MAYBE_ExternalPrerender DISABLED_ExternalPrerender
#else
#define MAYBE_ExternalPrerender ExternalPrerender
#define MAYBE_ExternalPrerender DISABLED_ExternalPrerender
#endif
IN_PROC_BROWSER_TEST_F(NoStatePrefetchBrowserTest, MAYBE_ExternalPrerender) {
GetProfile()->GetPrerenderController()->Prerender(
Expand Down
3 changes: 2 additions & 1 deletion weblayer/browser/origin_trials_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ class OriginTrialsBrowserTest : public WebLayerBrowserTest {
"https", kTrialEnabledDomain, 443);
return GetBrowserContext()
->GetOriginTrialsControllerDelegate()
->GetPersistedTrialsForOrigin(origin, base::Time::Now());
->GetPersistedTrialsForOrigin(origin, /*partition_origin*/ origin,
base::Time::Now());
}

void SetUpCommandLine(base::CommandLine* command_line) override {
Expand Down
17 changes: 9 additions & 8 deletions weblayer/browser/popup_blocker_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -130,18 +130,19 @@ class PopupBlockerBrowserTest : public WebLayerBrowserTest,
raw_ptr<Tab> new_tab_ = nullptr;
};

IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, BlocksPopup) {
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, DISABLED_BlocksPopup) {
ExecuteScript(original_tab(), "window.open('https://google.com')", true);
EXPECT_EQ(GetBlockedPopupCount(), 1u);
}

IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, BlocksMultiplePopups) {
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, DISABLED_BlocksMultiplePopups) {
ExecuteScript(original_tab(), "window.open('https://google.com')", true);
ExecuteScript(original_tab(), "window.open('https://google.com')", true);
EXPECT_EQ(GetBlockedPopupCount(), 2u);
}

IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, DoesNotBlockUserGesture) {
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
DISABLED_DoesNotBlockUserGesture) {
GURL popup_url = embedded_test_server()->GetURL("/echo?popup");
ExecuteScriptWithUserGesture(
original_tab(),
Expand All @@ -152,7 +153,7 @@ IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, DoesNotBlockUserGesture) {
EXPECT_EQ(GetBlockedPopupCount(), 0u);
}

IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, OpensBlockedPopup) {
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, DISABLED_OpensBlockedPopup) {
GURL popup_url = embedded_test_server()->GetURL("/echo?popup");
ExecuteScript(
original_tab(),
Expand All @@ -170,7 +171,7 @@ IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, OpensBlockedPopup) {
}

IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
AllowsPopupThroughContentSettingException) {
DISABLED_AllowsPopupThroughContentSettingException) {
GURL popup_url = embedded_test_server()->GetURL("/echo?popup");
HostContentSettingsMapFactory::GetForBrowserContext(
GetWebContents(original_tab())->GetBrowserContext())
Expand All @@ -186,7 +187,7 @@ IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
}

IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
AllowsPopupThroughContentSettingDefaultValue) {
DISABLED_AllowsPopupThroughContentSettingDefaultValue) {
GURL popup_url = embedded_test_server()->GetURL("/echo?popup");
HostContentSettingsMapFactory::GetForBrowserContext(
GetWebContents(original_tab())->GetBrowserContext())
Expand All @@ -201,7 +202,7 @@ IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
}

IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
BlockPopupThroughContentSettingException) {
DISABLED_BlockPopupThroughContentSettingException) {
GURL popup_url = embedded_test_server()->GetURL("/echo?popup");
HostContentSettingsMapFactory::GetForBrowserContext(
GetWebContents(original_tab())->GetBrowserContext())
Expand All @@ -219,7 +220,7 @@ IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
}

IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
BlocksAndOpensPopupFromOpenURL) {
DISABLED_BlocksAndOpensPopupFromOpenURL) {
GURL popup_url = embedded_test_server()->GetURL("/echo?popup");
content::OpenURLParams params(popup_url, content::Referrer(),
WindowOpenDisposition::NEW_FOREGROUND_TAB,
Expand Down
6 changes: 4 additions & 2 deletions weblayer/browser/profile_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ IN_PROC_BROWSER_TEST_F(ProfileBrowserTest, PersistNetworkPrediction) {

#endif // !BUILDFLAG(IS_ANDROID)

IN_PROC_BROWSER_TEST_F(ProfileBrowserTest, GetCachedFaviconForPageUrl) {
IN_PROC_BROWSER_TEST_F(ProfileBrowserTest,
DISABLED_GetCachedFaviconForPageUrl) {
// Navigation to a page with a favicon.
ASSERT_TRUE(embedded_test_server()->Start());
TestFaviconFetcherDelegate fetcher_delegate;
Expand Down Expand Up @@ -75,7 +76,8 @@ IN_PROC_BROWSER_TEST_F(ProfileBrowserTest, GetCachedFaviconForPageUrl) {
run_loop.Run();
}

IN_PROC_BROWSER_TEST_F(ProfileBrowserTest, ClearBrowsingDataDeletesFavicons) {
IN_PROC_BROWSER_TEST_F(ProfileBrowserTest,
DISABLED_ClearBrowsingDataDeletesFavicons) {
// Navigate to a page with a favicon.
ASSERT_TRUE(embedded_test_server()->Start());
TestFaviconFetcherDelegate fetcher_delegate;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ class ReduceAcceptLanguageServiceTest : public WebLayerBrowserTest {
std::unique_ptr<ReduceAcceptLanguageServiceTester> service_tester_;
};

IN_PROC_BROWSER_TEST_F(ReduceAcceptLanguageServiceTest, GetAcceptLanguageList) {
IN_PROC_BROWSER_TEST_F(ReduceAcceptLanguageServiceTest,
DISABLED_GetAcceptLanguageList) {
tester()->VerifyFetchAcceptLanguageList({"en", "ja", "it"});
reduce_accept_language::ReduceAcceptLanguageService incognito_service(
settings_map(), prefs(), true);
Expand Down
9 changes: 5 additions & 4 deletions weblayer/browser/safe_browsing/safe_browsing_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingBrowserTest,
}

IN_PROC_BROWSER_TEST_F(SafeBrowsingBrowserTest,
NoAccessTokenFetchInBasicSafeBrowsing) {
DISABLED_NoAccessTokenFetchInBasicSafeBrowsing) {
SetSafeBrowsingEnabled(true);

GURL a_url(embedded_test_server()->GetURL("a.com", "/simple_page.html"));
Expand All @@ -448,8 +448,9 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingBrowserTest,
EXPECT_FALSE(access_token_fetch_delegate()->has_received_request());
}

IN_PROC_BROWSER_TEST_F(SafeBrowsingBrowserTest,
NoAccessTokenFetchInRealTimeUrlLookupsUnlessEnabled) {
IN_PROC_BROWSER_TEST_F(
SafeBrowsingBrowserTest,
DISABLED_NoAccessTokenFetchInRealTimeUrlLookupsUnlessEnabled) {
SetRealTimeURLLookupsEnabled(true);

GURL a_url(embedded_test_server()->GetURL("a.com", "/simple_page.html"));
Expand All @@ -475,7 +476,7 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingBrowserTest,
// completes due to Safe Browsing's timing out the access token fetch.
IN_PROC_BROWSER_TEST_F(
SafeBrowsingBrowserTest,
UnfulfilledAccessTokenFetchTimesOutAndNavigationCompletes) {
DISABLED_UnfulfilledAccessTokenFetchTimesOutAndNavigationCompletes) {
SetRealTimeURLLookupsEnabled(true);
EnableSafeBrowsingAccessTokenFetches();
access_token_fetch_delegate()->set_should_respond_to_request(false);
Expand Down

0 comments on commit 69c9a3a

Please sign in to comment.