-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
suggest: fix shifting suggestion window (reland)
This is a reland of crrev/c/3811193 with issues fixed. Currently the multi word suggestion window aligns itself underneath the relevant text in the currently focused input when a suggestion candidate is triggered and shown to the user. The alignment works very well, however there is a noticeable "shifting" of the window as the AssistiveWindowController class attempts to align the suggestion window based on events received. This is due to an unexpected ordering of events received to the AssistiveWindowController. A ShowSuggestion event may be received prior to SetBounds event (this is because surrounding text and cursor bounds updates are sent as two distinct events). To accomodate this, the CL adds a delay before showing a multi word suggestion to the user. The delay allows the two related events (ShowSuggestion and SetBounds) to be received before making the suggestion window visible to the user. BUG=b:241321719 Change-Id: If3f555f773555704df9b181710978c1afdf704dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827279 Reviewed-by: jhtin <jhtin@chromium.org> Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/main@{#1034973}
- Loading branch information
1 parent
d3a5afc
commit 6a1743f
Showing
4 changed files
with
111 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters