Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[GridNG] Implementation of NGGridLayoutAlgorithmTrackCollection
1. Refactoring `NGGridTrackRepeater` to store the `GridTrackSize` of its specified track definition; updating `NGGridTrackList::AddRepeater` to take the track sizes as a parameter and implicitly handle repeater indexes, which were unnecessarily specified by the caller. Adding grid track sizes in `NGGridTrackList` unit tests. 2. Fixing a bug in `NGGridBlockTrackCollection::FinalizeRanges` where ranges spanning implicit tracks after the explicit grid didn't resolve their respective repeater offsets correctly. 3. Introducing the concept of a "set" with the `NGGridSet` class; any range from the new algorithm collection is composed of distinct track definitions which compose a "set", see the class's definition for a detailed explanation of how these sets work. 4. Introducing `NGGridLayoutAlgorithmTrackCollection` - builds ranges and their respective sets from the `NGGridBlockTrackCollection` to be used in the track sizing algorithm in `NGGridLayoutAlgorithm`. 5. Adding unit tests for the new `NGGridLayoutAlgorithmTrackCollection` constructor and `NGGridLayoutAlgorithmTrackCollection::SetIterator`. Bug: 1045599 Change-Id: I31036f0cf91a958ed74ada31f5dce5d9087faf49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272126 Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Jacques Newman <janewman@microsoft.com> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#785679}
- Loading branch information