Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
history: don't handle db error during destruction
Handling of db errors is delayed using a posttask. ~HistoryBackend closes all the dbs. If closing the db results in an error, then a PostTask() is scheduled with a HistoryBackend that is part way through deletion. When the PostTask() runs, we get a uaf. This patch resets the error callback in ~HistoryBackend to ensure this doesn't happen. This means a db error is effectively ignored during shutdown. Presumably if the error is fatal, it'll be handled when the HistoryBackend is created again. BUG=1306507 TEST=none Change-Id: Ic158589a43e7bc2fd1f602fb2798ab500dc8d6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3538001 Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#983478}
- Loading branch information