Skip to content

Commit

Permalink
[iOS blink] iOS platform-specific rebaseline for fullscreen
Browse files Browse the repository at this point in the history
These changes involve iOS platform-specific rebaselining
tests results in the web-platform-tests

- compositor-touch-hit-rects-fullscreen-video-controls-expected.txt
- full-screen-min-max-width-height-iframe-expected.txt
- full-screen-with-flex-item-expected.txt
: Added an iOS platform-specific expected test results.
  The window size sets to 980x735 in iOS platform from this CL
  (see https://crrev.com/c/4615623), which is different from window size of other platforms.
  Therefore, we should create rebaseline test results for ios.

The recommended approach for rebaseline utilizes blink_tool.py.
However, due to the unavailability of the iOS platform on
'tryserver.blink', these results are generated manually.

Bug: 1421239
Change-Id: I857683625b10fe3f840dff7dee6a3338ea79faf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4861362
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Minju Kim <mkim@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1209972}
  • Loading branch information
Minju-kim-igalia authored and Chromium LUCI CQ committed Oct 16, 2023
1 parent d454e5c commit 7329916
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
This test makes sure that touch hit rects are reported for fullscreen HTML5 video control elements even when there is a document handler.

Should have single rect on document before fullscreen
handler: layer(980x735) has hit test rect (0,0 980x735)
handler: layer(980x735) has hit test rect (0,0 980x735)

EVENT(webkitfullscreenchange)
Should keep rect on document
handler: layer(980x735) has hit test rect (0,0 980x735)
handler: layer(980x735) has hit test rect (0,0 980x735)
handler: layer(980x735) has hit test rect (0,0 980x735)
handler: layer(980x735) has hit test rect (0,0 980x735)

Found composited video layer, as expected
END OF TEST

Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
EVENT(webkitfullscreenchange)
EXPECTED (computedStyle.minWidth == '0px') OK
EXPECTED (computedStyle.maxWidth == 'none') OK
EXPECTED (computedStyle.minHeight == '0px') OK
EXPECTED (computedStyle.maxHeight == 'none') OK
EXPECTED (computedStyle.width == '980px') OK
EXPECTED (computedStyle.height == '735px') OK
END OF TEST

Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Enter Fullscreen
EVENT(webkitfullscreenchange)
EVENT(webkitfullscreenchange)
EXPECTED (735 == '735') OK
END OF TEST

0 comments on commit 7329916

Please sign in to comment.