-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reland "Assign "click ancestor" default action to text nodes."
This is a reland of commit 622755d Original did not update test expectation files for fuchsia platform, we update them in this reland and add that bot to CQ. Original change's description: > Assign "click ancestor" default action to text nodes. > > Text nodes did not have any default action set by AXObject::Action(), > because they don't have a backing Element object. On the other hand, > ATs expect that clicking the text node inside a container has the same > effect as clicking on the container, and that was the cause of > crbug.com/1370076. To address the bug, we allowed ATs to run the > default action on nodes that don't have any, but a better solution > would have been to assign text nodes a default action, if their > parent node has any. > > This CL makes text nodes expose a "click ancestor" default action when > their parent has any default action. This is the same action that would > be assigned to containers which are inside a clickable parent, e.g. in > <a href="#"><div>link</div></a>, the <a> node has the action > "jump" and the <div> has "click ancestor". Now, the text node inside > the div would get "click ancestor", too. Alternatively, in the example > <a href="#">link</a>, the <a> would expose "jump" and the text node > would expose "click ancestor" after this CL. > > As a positive side effect, we also set the default action for nodes > corresponding to pseudo elements, following the same rules. > > We don't revert the workaround that allows ATs to run a default action > when it's "none" yet. We will address that with a DCHECK that detects > other potentially problematic situations. > > Bug: 1382034 > Change-Id: Ia99d86975486745f37860b7d3fc7fc0e39b04262 > AX-relnotes: Expose default action on text nodes to AX toolkits > Cq-Include-Trybots: luci.chromium.try:linux-blink-web-tests-force-accessibility-rel > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4009258 > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1075708} Bug: 1382034 Change-Id: I789a9f8ac0fb55a3258a5e69c677a27b422f48eb Cq-Include-Trybots: luci.chromium.try:fuchsia-x64-cast-receiver-rel,linux-blink-web-tests-force-accessibility-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4061232 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1076728}
- Loading branch information
Showing
66 changed files
with
412 additions
and
406 deletions.
There are no files selected for viewing
6 changes: 3 additions & 3 deletions
6
content/test/data/accessibility/aria/aria-current-expected-android-external.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
content/test/data/accessibility/html/a-expected-android-external.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
WebView focusable focused scrollable actions:[CLEAR_FOCUS, AX_FOCUS] bundle:[chromeRole="rootWebArea"] | ||
++View actions:[AX_FOCUS] bundle:[chromeRole="genericContainer"] | ||
++++View text:"null" contentDescription:"normal link" clickable focusable actions:[FOCUS, CLICK, AX_FOCUS, NEXT, PREVIOUS] bundle:[chromeRole="link", clickableScore="300", roleDescription="link", targetUrl="http://www.google.com/"] | ||
++++++TextView text:"normal link" actions:[AX_FOCUS, NEXT, PREVIOUS] bundle:[chromeRole="staticText"] | ||
++++++TextView text:"normal link" actions:[AX_FOCUS, NEXT, PREVIOUS] bundle:[chromeRole="staticText", clickableScore="100"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
content/test/data/accessibility/html/a-name-calc-expected-android-external.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.