Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Privacy Sandbox] Create the layout for the Ad Measurement subpage
This CL creates the layout for the Ad Measurement subpage for the Privacy Sandbox settings, connecting the toggle of the subpage to the respective prefs. Tests are added to check for enabling and disabling the toggle and that its sublabel is static regarding the toggle state. Preview: https://crbug.com/1378703#c109 Bug: 1378703, b/254412694, b/254412652, b/254412707 Change-Id: Ia654744d58b3e1cf586ffd5e5cb45735f9da6287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4071625 Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Gabriel Oliveira <gabolvr@google.com> Cr-Commit-Position: refs/heads/main@{#1078493}
- Loading branch information
Gabriel Oliveira
authored and
Chromium LUCI CQ
committed
Dec 2, 2022
1 parent
27b52a8
commit 74543cb
Showing
7 changed files
with
192 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 71 additions & 1 deletion
72
...sources/settings/privacy_page/privacy_sandbox/privacy_sandbox_ad_measurement_subpage.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,71 @@ | ||
| Ad Measurement subpage under construction. | ||
| <style include="settings-shared"> | ||
| .description-column { | ||
| padding: 0 var(--cr-section-padding); | ||
| width: 50%; | ||
| } | ||
|
|
||
| .description-header { | ||
| color: var(--google-blue-600); | ||
| font-weight: 500; | ||
| } | ||
|
|
||
| .description-item { | ||
| align-items: center; | ||
| column-gap: 16px; | ||
| display: flex; | ||
| padding: 16px 0; | ||
| } | ||
|
|
||
| .description-wrapper { | ||
| display: flex; | ||
| padding-top: 4px; | ||
| } | ||
|
|
||
| @media (prefers-color-scheme: dark) { | ||
| .description-header { | ||
| color: var(--google-blue-300); | ||
| } | ||
| } | ||
| </style> | ||
|
|
||
| <settings-toggle-button | ||
| id="adMeasurementToggle" | ||
| pref="{{prefs.privacy_sandbox.m1.ad_measurement_enabled}}" | ||
| label="$i18n{adMeasurementPageToggleLabel}" | ||
| sub-label="$i18n{adMeasurementPageToggleSubLabel}"> | ||
| </settings-toggle-button> | ||
| <div class="description-wrapper"> | ||
| <div class="description-column"> | ||
| <div class="description-header"> | ||
| $i18n{adMeasurementPageEnabledHeading} | ||
| </div> | ||
| <div role="list"> | ||
| <div class="description-item"> | ||
| <iron-icon icon="settings20:spam" aria-hidden="true"></iron-icon> | ||
| <div class="secondary"> | ||
| $i18n{adMeasurementPageEnabledBullet1} | ||
| </div> | ||
| </div> | ||
| <div class="description-item"> | ||
| <iron-icon icon="settings20:performance-max" aria-hidden="true"> | ||
| </iron-icon> | ||
| <div class="secondary"> | ||
| $i18n{adMeasurementPageEnabledBullet2} | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <div class="description-column"> | ||
| <div class="description-header"> | ||
| $i18n{adMeasurementPageConsiderHeading} | ||
| </div> | ||
| <div role="list"> | ||
| <div class="description-item"> | ||
| <iron-icon icon="settings:permissions" aria-hidden="true"></iron-icon> | ||
| <div class="secondary"> | ||
| $i18n{adMeasurementPageConsiderBullet1} | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters