-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Browser shutdown cleanups (no functional changes)."
This reverts commit 11936b3. Reason for revert: Crashy. Original change's description: > Browser shutdown cleanups (no functional changes). > > - Make ShutdownType an enum class. > - Introduce browser_shutdown::HasShutdownStarted as a convenience. > - Move some Win-specific relaunch code from AttemptRestart, which runs > fairly early in a restart that may never actually happen, into > upgrade_util::RelaunchChromeBrowserImpl, which performs the actual > restart. > - Switch from UMA macros to functions for one-shot metrics. > > BUG=958865 > > Change-Id: I75cd08c712d8bb7c674b4b5e413d79abc874bc39 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910098 > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Greg Thompson <grt@chromium.org> > Auto-Submit: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715730} TBR=treib@chromium.org,bcwhite@chromium.org,holte@chromium.org,grt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. (cherry picked from commit 0328367) Bug: 958865,1025638,1025634 Change-Id: Ia97829abe61fcfb362720ce74741a5d375bb811e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921973 Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#716146} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919766 Cr-Commit-Position: refs/branch-heads/3970@{#8} Cr-Branched-From: 55f4451-refs/heads/master@{#716057}
- Loading branch information
Showing
13 changed files
with
94 additions
and
122 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.