Skip to content

Commit

Permalink
[M118][infra] Use SSDs for 32-core linux builderless try builders.
Browse files Browse the repository at this point in the history
The try builders that run on 32-core linux machines all have long build
times. The pool of non-SSD 32-core builderless linux machines is only 4
machines, which can often lead to pending when there are multiple deps
rolls since they often include linux_chromium_cfi_rel_ng,
linux-official, android-official and/or fuchsia-official. The pool of
SSD 32-core builderless try machines often sits unused because it is
primarily used by branch compilator builds. This will switch all of the
try builders targeting linux 32-core builderless machines to request the
ssd dimension to speed them up, then the existing non-SSD machines can
be switched over.

(cherry picked from commit d14defe)

Change-Id: Ic1144fb152f3bffaaec331d84f16909a651d7c25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4973680
Reviewed-by: Struan Shrimpton <sshrimp@google.com>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1214425}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4977602
Cr-Commit-Position: refs/branch-heads/5993@{#1437}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
  • Loading branch information
kleerwater authored and Chromium LUCI CQ committed Oct 25, 2023
1 parent 928aad8 commit 77a9a3f
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
6 changes: 3 additions & 3 deletions infra/config/generated/luci/cr-buildbucket.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -10221,7 +10221,7 @@ buckets {
dimensions: "cpu:x86-64"
dimensions: "os:Ubuntu-22.04"
dimensions: "pool:luci.chromium.try"
dimensions: "ssd:0"
dimensions: "ssd:1"
exe {
cipd_package: "infra/chromium/bootstrapper/${platform}"
cipd_version: "latest"
Expand Down Expand Up @@ -12497,7 +12497,7 @@ buckets {
dimensions: "cpu:x86-64"
dimensions: "os:Ubuntu-22.04"
dimensions: "pool:luci.chromium.try"
dimensions: "ssd:0"
dimensions: "ssd:1"
exe {
cipd_package: "infra/chromium/bootstrapper/${platform}"
cipd_version: "latest"
Expand Down Expand Up @@ -14689,7 +14689,7 @@ buckets {
dimensions: "cpu:x86-64"
dimensions: "os:Ubuntu-22.04"
dimensions: "pool:luci.chromium.try"
dimensions: "ssd:0"
dimensions: "ssd:1"
exe {
cipd_package: "infra/chromium/bootstrapper/${platform}"
cipd_version: "latest"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,7 @@ try_.builder(
"ci/Linux CFI",
],
cores = 32,
ssd = True,
# TODO(thakis): Remove once https://crbug.com/927738 is resolved.
execution_timeout = 7 * time.hour,
reclient_jobs = reclient.jobs.LOW_JOBS_FOR_CQ,
Expand Down Expand Up @@ -691,6 +692,7 @@ try_.builder(
executable = "recipe:chromium_toolchain/package_clang",
builderless = True,
cores = 32,
ssd = True,
execution_timeout = 5 * time.hour,
notifies = ["chrome-rust-toolchain"],
)
Expand All @@ -700,6 +702,7 @@ try_.builder(
executable = "recipe:chromium_toolchain/package_rust",
builderless = True,
cores = 32,
ssd = True,
execution_timeout = 5 * time.hour,
notifies = ["chrome-rust-toolchain"],
)
Expand Down
3 changes: 3 additions & 0 deletions infra/config/subprojects/chromium/try/tryserver.chromium.star
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ try_.builder(
mirrors = [
"ci/android-official",
],
ssd = True,
)

try_.builder(
Expand All @@ -44,6 +45,7 @@ try_.builder(
mirrors = [
"ci/fuchsia-official",
],
ssd = True,
)

try_.builder(
Expand All @@ -52,6 +54,7 @@ try_.builder(
mirrors = [
"ci/linux-official",
],
ssd = True,
)

try_.builder(
Expand Down

0 comments on commit 77a9a3f

Please sign in to comment.