-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reland "Add declarative AttributePart syntax parsing and functionality"
This is a reland of commit 5a66ab6 The original was missing an initializer for the vector. Original change's description: > Add declarative AttributePart syntax parsing and functionality > > This adds the ability to parse declarative AttributePart syntax: > > <div id={{}} class={{}}> > > The above snippet will now produce two "automatic" AttributeParts, > which do not show up in getParts() output, but which can be updated > while cloning via: > > root.clone({attributeValues: ['id_value', 'class_value']}); > > See [1] for more details. > > [1] https://docs.google.com/document/d/1z0YCj06-LFTWJlR_ayhtCOV2O4cJ5W1fHZbfckFsOdU/edit > > Bug: 1453291 > Change-Id: Icda4adbd3ce415999ff62e5a758124bd124188cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4930249 > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Commit-Queue: Mason Freed <masonf@chromium.org> > Auto-Submit: Mason Freed <masonf@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1209190} Bug: 1453291 Change-Id: I5c6887ff81e7d1f61d3fc8e48df3b34482c45e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4942513 Commit-Queue: Mason Freed <masonf@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1210536}
- Loading branch information
Mason Freed
authored and
Chromium LUCI CQ
committed
Oct 17, 2023
1 parent
a622c5f
commit 7800786
Showing
19 changed files
with
222 additions
and
81 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.