Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[M115] Use camelCase for enableDebugMode's debug key argument
i.e. debug_key -> debugKey. This would align with the web platform design principles: https://www.w3.org/TR/design-principles/#casing-rules Note that this does not change the JSON key used in the eventual report. This change is breaking, but code can be written to support both pre- and post-fix browsers to avoid compatibility issues, e.g.: ``` privateAggregation.enableDebugMode({debug_key: 123n, debugKey: 123n}); ``` (cherry picked from commit c542499) Bug: 1416320 Change-Id: I87413ccccab985e784fe8c87c86acf7435307f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4264741 Reviewed-by: Russ Hamilton <behamilton@google.com> Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Nan Lin <linnan@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1149858} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574539 Reviewed-by: Caleb Raitto <caraitto@chromium.org> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/branch-heads/5790@{#144} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
- Loading branch information
1 parent
c7ad670
commit 788efdd
Showing
7 changed files
with
16 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters