Implement <search> element

This was added to the HTML spec here: whatwg/html#7320 I mostly based on this on the webkit patch: WebKit/WebKit#13887 Bug: 1294294 Change-Id: Ia34836f7e5172d862a3a1f24f1e5cbcbb10e6a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4767222 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1184358}
chromium · Aug 16, 2023 · 7a8a002 · 7a8a002
1 parent 3cfe684
commit 7a8a002
Show file tree

Hide file tree

Showing 10 changed files with 15 additions and 21 deletions.
diff --git a/third_party/blink/renderer/core/html/html_tag_names.json5 b/third_party/blink/renderer/core/html/html_tag_names.json5
@@ -420,6 +420,11 @@
       name: "script",
       constructorNeedsCreateElementFlags: true,
     },
+    {
+      name: "search",
+      interfaceName: "HTMLElement",
+      runtimeEnabled: "HTMLSearchElement",
+    },
     {
       name: "section",
       interfaceName: "HTMLElement",

diff --git a/third_party/blink/renderer/core/html/parser/html_tree_builder.cc b/third_party/blink/renderer/core/html/parser/html_tree_builder.cc
@@ -723,6 +723,7 @@ void HTMLTreeBuilder::ProcessStartTagForInBody(AtomicHTMLToken* token) {
     case HTMLTag::kNav:
     case HTMLTag::kOl:
     case HTMLTag::kP:
+    case HTMLTag::kSearch:
     case HTMLTag::kSection:
     case HTMLTag::kSummary:
     case HTMLTag::kUl:
@@ -2032,6 +2033,7 @@ void HTMLTreeBuilder::ProcessEndTagForInBody(AtomicHTMLToken* token) {
     case HTMLTag::kNav:
     case HTMLTag::kOl:
     case HTMLTag::kPre:
+    case HTMLTag::kSearch:
     case HTMLTag::kSection:
     case HTMLTag::kSummary:
     case HTMLTag::kUl:

diff --git a/third_party/blink/renderer/core/html/resources/html.css b/third_party/blink/renderer/core/html/resources/html.css
@@ -54,7 +54,7 @@ div {
     display: block
 }
 
-article, aside, footer, header, hgroup, main, nav, section {
+article, aside, footer, header, hgroup, main, nav, search, section {
     display: block
 }
 

diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5
@@ -1977,6 +1977,10 @@
       name: "HTMLPopoverHint",
       status: "experimental",
     },
+    {
+      name: "HTMLSearchElement",
+      status: "experimental",
+    },
     {
       name: "HTMLSelectListElement",
       status: "experimental",

diff --git a/...ternal/wpt/html/rendering/non-replaced-elements/flow-content-0/search-styles-expected.txt b/...ternal/wpt/html/rendering/non-replaced-elements/flow-content-0/search-styles-expected.txt
@@ -1,5 +1,5 @@
 This is a testharness.js-based test.
-FAIL <search> - display assert_equals: expected "block" but got "inline"
+PASS <search> - display
 PASS <search> - margin-top
 PASS <search> - margin-right
 PASS <search> - margin-bottom

diff --git a/...html/rendering/non-replaced-elements/flow-content-0/search-styles-iso-8859-8-expected.txt b/...html/rendering/non-replaced-elements/flow-content-0/search-styles-iso-8859-8-expected.txt
@@ -1,6 +1,6 @@
 This is a testharness.js-based test.
 PASS Verify document.characterSet is ISO-8859-8
-FAIL <search> - display assert_equals: expected "block" but got "inline"
+PASS <search> - display
 PASS <search> - margin-top
 PASS <search> - margin-right
 PASS <search> - margin-bottom

diff --git a/..._tests/external/wpt/html/syntax/parsing/html5lib_search-element_run_type=uri-expected.txt b/..._tests/external/wpt/html/syntax/parsing/html5lib_search-element_run_type=uri-expected.txt
diff --git a/...ests/external/wpt/html/syntax/parsing/html5lib_search-element_run_type=write-expected.txt b/...ests/external/wpt/html/syntax/parsing/html5lib_search-element_run_type=write-expected.txt
diff --git a/...ternal/wpt/html/syntax/parsing/html5lib_search-element_run_type=write_single-expected.txt b/...ternal/wpt/html/syntax/parsing/html5lib_search-element_run_type=write_single-expected.txt
diff --git a/third_party/blink/web_tests/webexposed/element-instance-property-listing-expected.txt b/third_party/blink/web_tests/webexposed/element-instance-property-listing-expected.txt
@@ -969,6 +969,7 @@ html element script
     property src
     property text
     property type
+html element search
 html element section
 html element select
     property add