Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cros_next: make switch inherit from ToggleButton
Previously, we built the KnobSwitch class from scratch. However the existing ToggleButton has similar functionalities and also implements the animation, hover layer, ink drop layer and animation. To avoid re-invent the wheel, we decide to make KnobSwitch inherit from ToggleButton. This cl makes following changes: The changes in ui/views/controls/button/toggle_button.*: - Change the type of thumb on/off colors and track on/off colors from absl::optional to absl::variant<ui::ColorId, SkColor> such that they can hold both color ID and color value. - Update the enabled/disabled colors when the enabled state of ToggleButton is changed. - Add a new has_thumb_shadow_ attribute in ToggleButton such that the sub classes can specify if they want a thumb shadow. - Add a new has_shadow_ attribute in ThumbView to receive the value of has_thumb_shadow_ from ToggleButton. - Make GetFocusRingPath, GetTrackBounds and GetThumbBounds as virtual protected methods such the the sub classes can override them. - Add a protected method GetAnimationProgress for sub classes to get the value from slide animation. The changes in ash/style/ash_color_mixer - Change the toggle button related colors with dynamic color Id in ash color mixers. The changes in ash/style/knob_switch.* - Change the name from KnobSwitch to Switch because many people feel the name knob switch is confusing. - Inherit the Switch from ToggleButton and override the GetFocusRingPath, GetTrackBounds, and GetThumbBounds. The final effects will be shown in bug comment. Bug: b:271330235 Change-Id: I7051484ea80656ce97cc837fef79641a4b1708ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4338876 Reviewed-by: Sean Kau <skau@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118466}
- Loading branch information
Xiaodan Zhu
authored and
Chromium LUCI CQ
committed
Mar 17, 2023
1 parent
de4e3a6
commit 7be01b9
Showing
13 changed files
with
256 additions
and
270 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.