Skip to content

Commit

Permalink
Shard payments_section_test.ts to avoid test timeouts
Browse files Browse the repository at this point in the history
In crbug.com/1411294, this test was disabled due to flaky timeouts on
Linux Dbg. Investigation into the flake revealed that the test file
has gotten so big that loading it as a script source is taking over
20 seconds on Linux Dbg, and thus causing timeouts.

To reduce the huge script load time, this change shards the test file
by approximate sub-features.

Bug: 1411294
Change-Id: I6f5f8565c526a86fb053473dec4e130d420de505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4321930
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1115791}
  • Loading branch information
stephenmcgruer authored and Chromium LUCI CQ committed Mar 10, 2023
1 parent 4434c51 commit 8076a9f
Show file tree
Hide file tree
Showing 8 changed files with 1,366 additions and 1,250 deletions.
5 changes: 5 additions & 0 deletions chrome/test/data/webui/settings/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,13 @@ build_webui_tests("build") {
"passwords_import_dialog_test.ts",
"passwords_section_test.ts",
"password_view_test.ts",
"payments_section_card_rows_test.ts",
"payments_section_card_dialogs_test.ts",
"payments_section_iban_test.ts",
"payments_section_interactive_test.ts",
"payments_section_test.ts",
"payments_section_upi_test.ts",
"payments_section_utils.ts",
"people_page_sync_controls_test.ts",
"people_page_sync_page_interactive_test.ts",
"people_page_sync_page_test.ts",
Expand Down
11 changes: 5 additions & 6 deletions chrome/test/data/webui/settings/cr_settings_browsertest.js
Original file line number Diff line number Diff line change
Expand Up @@ -904,6 +904,11 @@ TEST_F('CrSettingsMenuTest', 'All', function() {
['PasswordView', 'password_view_test.js'],
['PasswordsExportDialog', 'passwords_export_dialog_test.js'],
['PasswordsImportDialog', 'passwords_import_dialog_test.js'],
['PaymentsSection', 'payments_section_test.js'],
['PaymentsSectionCardDialogs', 'payments_section_card_dialogs_test.js'],
['PaymentsSectionCardRows', 'payments_section_card_rows_test.js'],
['PaymentsSectionIban', 'payments_section_iban_test.js'],
['PaymentsSectionUpi', 'payments_section_upi_test.js'],
['PeoplePage', 'people_page_test.js'],
['PeoplePageSyncControls', 'people_page_sync_controls_test.js'],
['Prefs', 'prefs_tests.js'],
Expand Down Expand Up @@ -951,12 +956,6 @@ GEN('#if !(BUILDFLAG(IS_LINUX) && !defined(NDEBUG))');
test => registerTest(...test));
GEN('#endif');

// Flaky on Linux dbg bots: https://crbug.com/1411294
GEN('#if !(BUILDFLAG(IS_LINUX) && !defined(NDEBUG))');
[['PaymentsSection', 'payments_section_test.js']].forEach(
test => registerTest(...test));
GEN('#endif');

GEN('#if BUILDFLAG(IS_CHROMEOS)');
[['PasswordsSectionCros', 'passwords_section_test_cros.js'],
].forEach(test => registerTest(...test));
Expand Down

0 comments on commit 8076a9f

Please sign in to comment.