Skip to content

Commit

Permalink
Revert "[IntentHandling] Enable intent picker PWA persistence flag by…
Browse files Browse the repository at this point in the history
… default."

This reverts commit 74c939e.

Reason for revert: This feature if punted to launch after we get a
app management page to manage the intent preference.

Original change's description:
> [IntentHandling] Enable intent picker PWA persistence flag by default.
>
> This CL enables the intent picker PWA persistence flag by default. This
> allows user to store the user selection for PWA in the intent picker.
> Also the intent picker will auto pop up for PWA, and for preferred PWA
> the navigation will directly open in PWA.
>
> BUG=853604, 1160135
>
> Change-Id: I283e12428bf63af32f9baf95496dc808d4ad542f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501101
> Commit-Queue: Maggie Cai <mxcai@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#847462}

BUG=1184541

Bug: 853604
Bug: 1160135
Change-Id: I085a4569f7a59064430da3b60172cdca3cc081d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2738738
Reviewed-by: Melissa Zhang <melzhang@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/branch-heads/4430@{#213}
Cr-Branched-From: e5ce7dc-refs/heads/master@{#857950}
  • Loading branch information
Maggie Cai authored and Chromium LUCI CQ committed Mar 8, 2021
1 parent a6d8fab commit 80bfe84
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions chrome/common/chrome_features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -561,12 +561,7 @@ const base::Feature kIntentHandlingSharing{"IntentHandlingSharing",
base::FEATURE_ENABLED_BY_DEFAULT};
// Allow user to have preference for PWA in the intent picker.
const base::Feature kIntentPickerPWAPersistence{
#if BUILDFLAG(IS_CHROMEOS_ASH)
"IntentPickerPWAPersistence", base::FEATURE_ENABLED_BY_DEFAULT
#else
"IntentPickerPWAPersistence", base::FEATURE_DISABLED_BY_DEFAULT
#endif // BUILDFLAG(IS_CHROMEOS_ASH)
};
"IntentPickerPWAPersistence", base::FEATURE_DISABLED_BY_DEFAULT};
#endif // !defined(OS_ANDROID)

// If enabled, CloudPolicyInvalidator and RemoteCommandInvalidator instances
Expand Down

0 comments on commit 80bfe84

Please sign in to comment.