Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "[Bundles] Add module_installer_backend.cc with native OnInsta…
…llModule handler." This reverts commit 461a68d. Reason for revert: This is no longer needed: We've decided to let each DFM load native resources (on install) in its own way, instead of relying on common infrastructure. Reverting this also fixes crbug.com/994035 Original change's description: > [Bundles] Add module_installer_backend.cc with native OnInstallModule handler. > > To prepare for handling native resource loading after DFM installation, > this CL adds a new hook in ModuleInstallerBackend.onFinished() to call > (via JNI) a new native handler for each newly installed module: > JNI_ModuleInstallerBackend_OnInstallModule() > > AsyncTask is used to make the JNI call asynchronous, taking place > outside the UI thread. This allows file access (e.g., to open native > resources) to take place in the native code, thereby preventing > assert failure in Debug builds. > > After the JNI call, |mListener.onFinished()| is called on UI thread, > just like before. > > Bug: 927131 > Change-Id: I36880cc7739a48534052b51d3d655d1ae0beb29a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702905 > Commit-Queue: Samuel Huang <huangs@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680452} TBR=danakj@chromium.org,huangs@chromium.org,agrieve@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 927131,994035 Change-Id: If9fdbffb35d226615135c9db596ad50960bc2958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756154 Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#687309}
- Loading branch information