Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Initial version of HTTPS-First Mode V2"
This reverts commit f5cf563. Reason for revert: Tests are broken: https://ci.chromium.org/p/chromium/builders/ci/linux-bfcache-rel?limit=200 https://ci.chromium.org/p/chromium/builders/ci/Mac11%20Tests Original change's description: > Initial version of HTTPS-First Mode V2 > > This adds a rearchitected version of HTTPS-First Mode to address some > edge cases that occurred in the initial version, behind a new > kHttpsFirstModeV2 flag. The new version cancels the upgraded > inavigation when it fails (or times out) and initiates a new fallback > HTTP navigation. That fallback navigation is then replaced with the > HTTPS-First Mode interstitial warning. This addresses a number of > issues such as showing the HTTPS URL when the interstitial is showing > (crbug.com/1257272), sometimes losing history entries when going > back/forward from an HTTPS-First Mode interstitial > (crbug.com/crbug.com/1272781), and will allow follow-up work to better > handle interactions with network errors (crbug.com/1277211) among > others. > > This rearchitecture will also allow us to more easily add the new > HTTPS Upgrades feature > (https://chromestatus.com/feature/6056181032812544). > > Bug: 1394910,1257272,1272781,1277211 > Change-Id: I787ecff185ab78099c04b458441c302cc254eb06 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4114422 > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Commit-Queue: Chris Thompson <cthomp@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1084642} Bug: 1394910,1257272,1272781,1277211 Change-Id: Iec9de2651521cab74eb4df54589eaa5c774ac2fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4113622 Auto-Submit: Nancy Wang <nancylingwang@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1084823}
- Loading branch information
Nancy Wang
authored and
Chromium LUCI CQ
committed
Dec 19, 2022
1 parent
f51d6a3
commit 814369b
Showing
17 changed files
with
7 additions
and
1,688 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.