Skip to content

Commit

Permalink
[M90] Cherry pick - Add cached flag params
Browse files Browse the repository at this point in the history
LensFeature.DISABLE_LENS_CAMERA_ASSISTED_SEARCH_ON_INCOGNITO,
LensFeature.ENABLE_LENS_CAMERA_ASSISTED_SEARCH_ON_LOW_END_DEVICE,
LensFeature.MIN_AGSA_VERSION_LENS_CAMERA_ASSISTED_SEARCH,

(cherry picked from commit 419c16c)

Change-Id: I21761280f177220511632136565478d3a15af656
Bug: 1182650,1182635
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2724835
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Yu Su <yusuyoutube@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#858373}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2725299
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/4430@{#32}
Cr-Branched-From: e5ce7dc-refs/heads/master@{#857950}
  • Loading branch information
Yu Su authored and Chromium LUCI CQ committed Mar 1, 2021
1 parent 9c081b0 commit 830544e
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 0 deletions.
1 change: 1 addition & 0 deletions chrome/android/chrome_java_sources.gni
Expand Up @@ -745,6 +745,7 @@ chrome_java_sources = [
"java/src/org/chromium/chrome/browser/language/settings/LanguageSettings.java",
"java/src/org/chromium/chrome/browser/lens/LensController.java",
"java/src/org/chromium/chrome/browser/lens/LensEntryPoint.java",
"java/src/org/chromium/chrome/browser/lens/LensFeature.java",
"java/src/org/chromium/chrome/browser/lens/LensIntentParams.java",
"java/src/org/chromium/chrome/browser/lens/LensQueryParams.java",
"java/src/org/chromium/chrome/browser/lens/LensQueryResult.java",
Expand Down
Expand Up @@ -13,6 +13,7 @@
import org.chromium.chrome.browser.flags.CachedFeatureFlags;
import org.chromium.chrome.browser.flags.CachedFieldTrialParameter;
import org.chromium.chrome.browser.flags.ChromeFeatureList;
import org.chromium.chrome.browser.lens.LensFeature;
import org.chromium.chrome.browser.page_annotations.PageAnnotationsServiceConfig;
import org.chromium.chrome.browser.paint_preview.StartupPaintPreviewHelper;
import org.chromium.chrome.browser.tab.state.ShoppingPersistedTabData;
Expand Down Expand Up @@ -97,6 +98,9 @@ public void cacheNativeFlags() {
ConditionalTabStripUtils.CONDITIONAL_TAB_STRIP_INFOBAR_LIMIT,
ConditionalTabStripUtils.CONDITIONAL_TAB_STRIP_INFOBAR_PERIOD,
ConditionalTabStripUtils.CONDITIONAL_TAB_STRIP_SESSION_TIME_MS,
LensFeature.DISABLE_LENS_CAMERA_ASSISTED_SEARCH_ON_INCOGNITO,
LensFeature.ENABLE_LENS_CAMERA_ASSISTED_SEARCH_ON_LOW_END_DEVICE,
LensFeature.MIN_AGSA_VERSION_LENS_CAMERA_ASSISTED_SEARCH,
PageAnnotationsServiceConfig.PAGE_ANNOTATIONS_BASE_URL,
ReturnToChromeExperimentsUtil.TAB_SWITCHER_ON_RETURN_MS,
ShoppingPersistedTabData.TIME_TO_LIVE_MS,
Expand Down
@@ -0,0 +1,32 @@
// Copyright 2021 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

package org.chromium.chrome.browser.lens;

import org.chromium.chrome.browser.flags.BooleanCachedFieldTrialParameter;
import org.chromium.chrome.browser.flags.ChromeFeatureList;
import org.chromium.chrome.browser.flags.StringCachedFieldTrialParameter;

public class LensFeature {
private static final String DISABLE_ON_INCOGNITO_PARAM_NAME = "disableOnIncognito";
public static final BooleanCachedFieldTrialParameter
DISABLE_LENS_CAMERA_ASSISTED_SEARCH_ON_INCOGNITO = new BooleanCachedFieldTrialParameter(
ChromeFeatureList.LENS_CAMERA_ASSISTED_SEARCH, DISABLE_ON_INCOGNITO_PARAM_NAME,
true);

private static final String ENABLE_LENS_CAMERA_ASSISTED_SEARCH_ON_LOW_END_DEVICE_PARAM_NAME =
"enableCameraAssistedSearchOnLowEndDevice";
public static final BooleanCachedFieldTrialParameter
ENABLE_LENS_CAMERA_ASSISTED_SEARCH_ON_LOW_END_DEVICE =
new BooleanCachedFieldTrialParameter(
ChromeFeatureList.LENS_CAMERA_ASSISTED_SEARCH,
ENABLE_LENS_CAMERA_ASSISTED_SEARCH_ON_LOW_END_DEVICE_PARAM_NAME, false);

private static final String MIN_AGSA_VERSION_LENS_CAMERA_ASSISTED_SEARCH_PARAM_NAME =
"minAgsaVersionForLensCameraAssistedSearch";
public static final StringCachedFieldTrialParameter
MIN_AGSA_VERSION_LENS_CAMERA_ASSISTED_SEARCH = new StringCachedFieldTrialParameter(
ChromeFeatureList.LENS_CAMERA_ASSISTED_SEARCH,
MIN_AGSA_VERSION_LENS_CAMERA_ASSISTED_SEARCH_PARAM_NAME, "12.7");
}

0 comments on commit 830544e

Please sign in to comment.