Skip to content

Commit

Permalink
Add a wpt test for issue 916631.
Browse files Browse the repository at this point in the history
Bug: 916631
Change-Id: I307aac195ddb9c30ff7408f6f33f729669f5a855
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923287
Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Auto-Submit: Emilio Cobos Álvarez <emilio@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716416}
  • Loading branch information
emilio authored and Commit Bot committed Nov 19, 2019
1 parent 69c98d5 commit 8360e2e
Show file tree
Hide file tree
Showing 2 changed files with 49 additions and 0 deletions.
2 changes: 2 additions & 0 deletions third_party/blink/web_tests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,8 @@ crbug.com/591099 external/wpt/css/css-ui/text-overflow-015.html [ Failure ]

crbug.com/1003506 external/wpt/css/css-flexbox/percentage-heights-007.html [ Failure ]

crbug.com/916631 external/wpt/css/cssom-view/scrollIntoView-horizontal-partially-visible.html [ Failure ]

# ====== Layout team owned tests to here ======

# ====== LayoutNG-only failures from here ======
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
<!doctype html>
<title>CSSOM View - scrollIntoView scrolls partially-visible element in both inline and block directions.</title>
<meta charset="utf-8">
<link rel="author" title="Emilio Cobos Álvarez" href="mailto:emilio@crisal.io">
<link rel="author" title="Mozilla" href="https://mozilla.org">
<link rel="help" href="https://drafts.csswg.org/cssom-view/#dom-element-scrollintoview">
<link rel="help" href="https://bugs.webkit.org/show_bug.cgi?id=203497">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=916631">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<style>
#scroller {
width: 200px;
height: 200px;
padding-top: 200px;
padding-left: 200px;
background: purple;
overflow: hidden;
}
#child {
width: 400px;
height: 400px;
background: green;
}
</style>
<div id="scroller">
<div id="child"></div>
</div>
<script>
test(function() {
let scroller = document.getElementById("scroller");
let child = document.getElementById("child");

scroller.scrollTop = 0;
scroller.scrollLeft = 0;

assert_equals(scroller.scrollTop, 0, "Precondition");
assert_equals(scroller.scrollLeft, 0, "Precondition");
assert_not_equals(scroller.scrollTopMax, 0, "Precondition")
assert_not_equals(scroller.scrollLeftMax, 0, "Precondition")

child.scrollIntoView();

assert_equals(scroller.scrollTop, 200, "Should have scrolled in the block direction");
assert_equals(scroller.scrollLeft, 200, "Should have scrolled in the inline direction");
}, "scrollIntoView scrolls partially-visible child in both axes");
</script>

0 comments on commit 8360e2e

Please sign in to comment.