[Merge-M103][Passwords] NewlySavedPasswordHasEmptyUsername metric

I want to measure the necessity of username editing in a generation confirmation bubble/infobar. (cherry picked from commit 1b1a0fb, the merge conflict with crrev.com/c/3649663 is resolved) Bug: 1328798 Change-Id: I266109df5e550f990561a27c94268d8a4880e257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3663286 Reviewed-by: Ioana Pandele <ioanap@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1008196} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3673067 Cr-Commit-Position: refs/branch-heads/5060@{#383} Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
chromium · May 30, 2022 · 83a2ef2 · 83a2ef2
1 parent 9682bbb
commit 83a2ef2
Show file tree

Hide file tree

Showing 6 changed files with 75 additions and 8 deletions.
diff --git a/components/password_manager/core/browser/BUILD.gn b/components/password_manager/core/browser/BUILD.gn
@@ -706,6 +706,7 @@ source_set("unit_tests") {
     "password_manager_client_helper_unittest.cc",
     "password_manager_features_util_unittest.cc",
     "password_manager_metrics_recorder_unittest.cc",
+    "password_manager_metrics_util_unittest.cc",
     "password_manager_unittest.cc",
     "password_manager_util_unittest.cc",
     "password_notes_table_unittest.cc",

diff --git a/components/password_manager/core/browser/password_manager_metrics_util.cc b/components/password_manager/core/browser/password_manager_metrics_util.cc
@@ -283,15 +283,25 @@ void LogDeleteUndecryptableLoginsReturnValue(
       "PasswordManager.DeleteUndecryptableLoginsReturnValue", result);
 }
 
-void LogNewlySavedPasswordIsGenerated(
-    bool value,
+void LogNewlySavedPasswordMetrics(
+    bool is_generated_password,
+    bool is_username_empty,
     PasswordAccountStorageUsageLevel account_storage_usage_level) {
   base::UmaHistogramBoolean("PasswordManager.NewlySavedPasswordIsGenerated",
-                            value);
+                            is_generated_password);
   std::string suffix = GetPasswordAccountStorageUsageLevelHistogramSuffix(
       account_storage_usage_level);
   base::UmaHistogramBoolean(
-      "PasswordManager.NewlySavedPasswordIsGenerated." + suffix, value);
+      "PasswordManager.NewlySavedPasswordIsGenerated." + suffix,
+      is_generated_password);
+
+  base::UmaHistogramBoolean(
+      "PasswordManager.NewlySavedPasswordHasEmptyUsername.Overall",
+      is_username_empty);
+  base::UmaHistogramBoolean(
+      base::StrCat({"PasswordManager.NewlySavedPasswordHasEmptyUsername.",
+                    is_generated_password ? "AutoGenerated" : "UserCreated"}),
+      is_username_empty);
 }
 
 void LogGenerationDialogChoice(GenerationDialogChoice choice,

diff --git a/components/password_manager/core/browser/password_manager_metrics_util.h b/components/password_manager/core/browser/password_manager_metrics_util.h
@@ -663,9 +663,11 @@ void LogPasswordSettingsReauthResult(ReauthResult result);
 void LogDeleteUndecryptableLoginsReturnValue(
     DeleteCorruptedPasswordsResult result);
 
-// Log whether a saved password was generated.
-void LogNewlySavedPasswordIsGenerated(
-    bool value,
+// Log metrics about a newly saved password (e.g. whether a saved password was
+// generated).
+void LogNewlySavedPasswordMetrics(
+    bool is_generated_password,
+    bool is_username_empty,
     PasswordAccountStorageUsageLevel account_storage_usage_level);
 
 // Log whether the generated password was accepted or rejected for generation of

diff --git a/components/password_manager/core/browser/password_manager_metrics_util_unittest.cc b/components/password_manager/core/browser/password_manager_metrics_util_unittest.cc
@@ -0,0 +1,41 @@
+// Copyright 2022 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/password_manager/core/browser/password_manager_metrics_util.h"
+
+#include "base/test/metrics/histogram_tester.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace password_manager::metrics_util {
+
+TEST(PasswordManagerMetricsUtil, LogNewlySavedPasswordMetrics) {
+  base::HistogramTester histogram_tester;
+
+  constexpr bool kIsGeneratedPassword = true;
+  constexpr bool kIsUsernameEmpty = true;
+  LogNewlySavedPasswordMetrics(
+      /*is_generated_password=*/true, /*is_username_empty=*/true,
+      PasswordAccountStorageUsageLevel::kNotUsingAccountStorage);
+
+  histogram_tester.ExpectUniqueSample(
+      "PasswordManager.NewlySavedPasswordIsGenerated", kIsGeneratedPassword, 1);
+  histogram_tester.ExpectUniqueSample(
+      "PasswordManager.NewlySavedPasswordIsGenerated.NotUsingAccountStorage",
+      kIsGeneratedPassword, 1);
+  histogram_tester.ExpectTotalCount(
+      "PasswordManager.NewlySavedPasswordIsGenerated.UsingAccountStorage", 0);
+  histogram_tester.ExpectTotalCount(
+      "PasswordManager.NewlySavedPasswordIsGenerated.Syncing", 0);
+
+  histogram_tester.ExpectUniqueSample(
+      "PasswordManager.NewlySavedPasswordHasEmptyUsername.Overall",
+      kIsUsernameEmpty, 1);
+  histogram_tester.ExpectUniqueSample(
+      "PasswordManager.NewlySavedPasswordHasEmptyUsername.AutoGenerated",
+      kIsUsernameEmpty, 1);
+  histogram_tester.ExpectTotalCount(
+      "PasswordManager.NewlySavedPasswordHasEmptyUsername.UserCreated", 0);
+}
+
+}  // namespace password_manager::metrics_util
diff --git a/components/password_manager/core/browser/password_save_manager_impl.cc b/components/password_manager/core/browser/password_save_manager_impl.cc
@@ -780,8 +780,9 @@ void PasswordSaveManagerImpl::UploadVotesAndMetrics(
 #endif  // !BUILDFLAG(IS_ANDROID)
 
   if (IsNewLogin()) {
-    metrics_util::LogNewlySavedPasswordIsGenerated(
+    metrics_util::LogNewlySavedPasswordMetrics(
         pending_credentials_.type == PasswordForm::Type::kGenerated,
+        pending_credentials_.username_value.empty(),
         client_->GetPasswordFeatureManager()
             ->ComputePasswordAccountStorageUsageLevel());
     // Don't send votes if there was no observed form.

diff --git a/tools/metrics/histograms/metadata/password/histograms.xml b/tools/metrics/histograms/metadata/password/histograms.xml
@@ -1897,6 +1897,18 @@ chromium-metrics-reviews@google.com.
   </summary>
 </histogram>
 
+<histogram
+    name="PasswordManager.NewlySavedPasswordHasEmptyUsername.{PasswordType}"
+    enum="Boolean" expires_after="2022-10-23">
+  <owner>khamutov@google.com</owner>
+  <owner>kolos@chromium.org</owner>
+  <summary>
+    Whether a newly saved password has an empty username. Recorded right before
+    a new credential is commited to the store.
+  </summary>
+  <token key="PasswordType" variants="PasswordType"/>
+</histogram>
+
 <histogram name="PasswordManager.NewlySavedPasswordIsGenerated"
     enum="BooleanNewlySavedPasswordIsGenerated" expires_after="2022-10-23">
   <owner>nepper@chromium.org</owner>