-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "FLEDGE: Report additional bids to devtools, too."
This reverts commit 124b109. Reason for revert: frequent flaky failures of http/tests/inspector-protocol/storage/interest-groups.js such as in: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/135180 https://ci.chromium.org/ui/p/chromium/builders/ci/linux-bfcache-rel/51047/overview https://ci.chromium.org/ui/p/chromium/builders/ci/Mac12%20Tests/12875/overview https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Win10/122043/overview Original change's description: > FLEDGE: Report additional bids to devtools, too. > > This mostly involves splitting out the reporting from > InterestGroupManagerImpl::RecordInterestGroupBids and RecordInterestGroupWin and just doing it directly (and, for bids, also at earlier time --- waiting for the reporter to notify devtools of those doesn't seem necessary). > > Two new enum value is also added for additional bids + them winning, to distinguish them from regular DB bids, which have separate namespace. > > Bug: 1475640 > Change-Id: I831d13584edd764d6f4530c42a3e4620f09b3262 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4873598 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Russ Hamilton <behamilton@google.com> > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1198450} Bug: 1475640 Change-Id: I203d509a0e6c29cb8de4597ef4090cafd4783b8e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4873434 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: David Baron <dbaron@chromium.org> Auto-Submit: David Baron <dbaron@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1198598}
- Loading branch information
Showing
12 changed files
with
49 additions
and
133 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.